Change find-all-references tests to test for groups #13760
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
* Also always test for isWriteAccess and isDefinition
ghost
force-pushed
the
find_all_refs_tests
branch
from
8e9f997 to
8515f7e
Compare
sandersn
approved these changes
Feb 7, 2017
src/harness/fourslash.ts
Outdated
|
|
||
| function rangeToReferenceEntry(r: Range) { | ||
| let { isWriteAccess, isDefinition } = (r.marker && r.marker.data) || { isWriteAccess: false, isDefinition: false }; | ||
| isWriteAccess = isWriteAccess || false; isDefinition = isDefinition || false; |
There was a problem hiding this comment.
isn't this almost a conversion to boolean? Technically, a conversion to T | false, I guess, but a full conversion via !! would be better I think.
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isWriteAccessandisDefinitionNote: removed duplicates:
findAllRefsForDefaultExport04andfindAllRefsForDefaultExport05andfindAllRefsForDefaultExport06duplicatefindAllRefsForDefaultExport03findAllRefsForDefaultExport07now merged withfindAllRefsForDefaultExport02findAllRefsObjectBindingElementPropertyName09duplicatesfindAllRefsObjectBindingElementPropertyName04