Support find-all-references for type keywords #13566
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
force-pushed
the
find_all_refs_primitive
branch
from
abb0a29 to
2d232c2
Compare
mhegazy
reviewed
Jan 18, 2017
| forEachChild(jsDoc, walk); | ||
| break; | ||
| default: | ||
| if (isTypeKeyword(node.kind)) { |
There was a problem hiding this comment.
does this buy you much really.. like string, number will likely be in each file, might as well do the search.
mhegazy
reviewed
Jan 18, 2017
| case SyntaxKind.BooleanKeyword: | ||
| case SyntaxKind.NeverKeyword: | ||
| case SyntaxKind.NumberKeyword: | ||
| case SyntaxKind.KeyOfKeyword: |
There was a problem hiding this comment.
what does find all refs on keyof T mean?
ghost
force-pushed
the
find_all_refs_primitive
branch
from
1571762 to
6695ae1
Compare
ghost
force-pushed
the
find_all_refs_primitive
branch
from
6695ae1 to
36a9f67
Compare
mhegazy
approved these changes
Jan 20, 2017
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13473