Fixed bug where tagged templates with a literal adjacent to EOF showed sig help past the end. #1271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielRosenwasser
changed the title
| // If we did, make sure that it's not the *initial* backtick. | ||
| return sourceText.charCodeAt(node.end - 1) !== CharacterCodes.backtick || node.text.length === 0; | ||
| // If we didn't end in a backtick, we must still be in the middle of a template literal, | ||
| // but if it's the *initial* backtick (whereby the token is 1 char long), then it's unclosed. |
There was a problem hiding this comment.
Not sure I understand this line of comment
Conflicts: src/compiler/parser.ts src/services/signatureHelp.ts
|
👍 |
DanielRosenwasser
added a commit
that referenced
this pull request
Feb 12, 2015
Fixed bug where tagged templates with a literal adjacent to EOF showed sig help past the end.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.