Turn on noEmit for inferred / external projects without ts files #11968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhengbli
force-pushed
the
noEmitForInferred
branch
from
f5157ef to
191b45e
Compare
billti
reviewed
Oct 31, 2016
| @@ -471,6 +471,15 @@ namespace ts.server { | |||
| // - newProgram is different from the old program and structure of the old program was not reused. | |||
| if (!oldProgram || (this.program !== oldProgram && !oldProgram.structureIsReused)) { | |||
| hasChanges = true; | |||
|
|
|||
| const options = this.getCompilerOptions(); | |||
| if ((this.projectKind === ProjectKind.Inferred || this.projectKind === ProjectKind.External) && !options.noEmit && allFilesAreJsOrDts(this)) { | |||
There was a problem hiding this comment.
updateGraphWorker doesn't seem to be the right place to be setting default options. Isn't there some other place we typically do this? Chat with Vlad/Mohamed about where setting this would best live (if you haven't already - in which case ignore me!).
|
As discussed offline, setting "noEmit" flag is not the optimal approach to solve this issue. A new proposal is posted at #11980 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11649