[Release-2.1] Fix declaration emit when using type parameters #11931
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 28, 2016 16:41
…artially fill type parameters
mhegazy
reviewed
Oct 28, 2016
| foo<U, J>(): Foo<U, J>; | ||
| }; | ||
| declare type SubFoo<R, S> = Foo<S, R>; | ||
| declare function foo(): Foo<number, string>; |
There was a problem hiding this comment.
this does not look right. this should be Foo<string, number>
mhegazy
reviewed
Oct 28, 2016
| @@ -2180,54 +2180,105 @@ namespace ts { | |||
| writer.writeKeyword(!(globalFlags & TypeFormatFlags.WriteOwnNameForAnyLike) && isTypeAny(type) | |||
| ? "any" | |||
| : (<IntrinsicType>type).intrinsicName); | |||
| return; | |||
There was a problem hiding this comment.
can you keep the else if for this change. it makes it easier to understand the extent of the change here.
mhegazy
approved these changes
Oct 31, 2016
|
@yuit can you please port this to master as well. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #11855