Skip to content

Fix 10505: Fix typo of missing node.kind #10569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 26, 2016
Merged

Fix 10505: Fix typo of missing node.kind #10569

merged 1 commit into from
Aug 26, 2016

Conversation

yuit
Copy link
Contributor

@yuit yuit commented Aug 26, 2016

Fixes #10505

@sandersn
Copy link
Member

👍

are we allowed to use 'naked' in our variable names? I've worked on code bases before where we had to change any names containing strings on a list of blocked words.

@yuit
Copy link
Contributor Author

yuit commented Aug 26, 2016

hmmm the conversation on block words has been brought up before. I don't know what is the conclusion there though @DanielRosenwasser @RyanCavanaugh @mhegazy would it matter?

@yuit yuit merged commit e62f118 into master Aug 26, 2016
@yuit yuit deleted the fix10505 branch August 26, 2016 23:46
@RyanCavanaugh
Copy link
Member

We used to have to run Policheck, but I don't think anyone's done that in years. It would probably be good to run that tool once just to make sure nothing crazy has snuck in; I imagine this one would have been flagged.

@mhegazy
Copy link
Contributor

mhegazy commented Aug 29, 2016

We used to have to run Policheck, but I don't think anyone's done that in years. It would probably be good to run that tool once just to make sure nothing crazy has snuck in; I imagine this one would have been flagged.

I still do this once every release :) usually it flags foo, ns, naked, ..., and my name :D

@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants