Add a helper function getOrUpdateProperty to prevent unprotected access to Maps.
#10115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
ghost
force-pushed
the
export_specifiers_map
branch
from
6373853 to
204f2c1
Compare
| @@ -941,7 +945,7 @@ namespace ts { | |||
| * [^./] # matches everything up to the first . character (excluding directory seperators) | |||
| * (\\.(?!min\\.js$))? # matches . characters but not if they are part of the .min.js file extension | |||
| */ | |||
| const singleAsteriskRegexFragmentFiles = "([^./]|(\\.(?!min\\.js$))?)*"; | |||
| const singleAsteriskRegexFragmentFiles = "([^./]|(\\.(?!min\\.js$))?)*"; | |||
There was a problem hiding this comment.
what changes on this line? Is it the line ending?
There was a problem hiding this comment.
It's line ending. This line ends with just an LF in master.
Which is strange, because we have a lint rule covering this which is not triggering.
There was a problem hiding this comment.
Does it only detect extra line endings? It just fired for me when I had an extra.
|
👍 |
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9732