-
Notifications
You must be signed in to change notification settings - Fork 12.8k
RangeError: Maximum call stack size exceeded when building monaco (5.5.2) #59253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
The error:
|
|
Also, this goes away if you drop the config for |
Huh, funny. Two things I wanna do then:
|
So, weirdly enough, this is fixed in In any case, that makes this "fixed", but to my second point above, I've opened #59398 with the fast bail-outs to avoid the reference walking pass in some common cases that don't need it. @DanielRosenwasser this is scheduled for a patch release, but #59183 seems like an odd change to port, being a behavioral change - how do you feel about this? |
π Search Terms
"maximum call stack size"
π Version & Regression Information
β― Playground Link
No response
π» Code
Not sure which code causes the crash.
π Actual behavior
When compiling monaco-editor with [email protected] or higher, it will result in a
Maximum call stack size exceeded
.npm run build-monaco-editor
(this will work as it uses [email protected])npm install [email protected]
npm run build-monaco-editor
again (this will fail)π Expected behavior
When compiling
monaco-editor
with the latest TypeScript, I shouldn't be seeing aMaximum call stack size exceeded
.Additional information about the issue
No response
The text was updated successfully, but these errors were encountered: