Skip to content

Format code doesn't do the right thing with TSX/JSX #5925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dbaeumer opened this issue Dec 4, 2015 · 2 comments
Closed

Format code doesn't do the right thing with TSX/JSX #5925

dbaeumer opened this issue Dec 4, 2015 · 2 comments
Labels
Duplicate An existing issue was already created

Comments

@dbaeumer
Copy link
Member

dbaeumer commented Dec 4, 2015

From @prencher on December 3, 2015 20:0

When formatting the following snippet:

ReactDOM.render(
    <Router history={createHistory() }>
        <Route path='/' component={App}>
            <IndexRoute component={SplashView} />
            <Route path='home' component={HomeView} />
            <Route path='chat' component={ChatView} />
            <Route path='/chat/:contact' component={ChatView} />
        </Route>
    </Router>,
    document.getElementById('app')
);

The closing tags are not properly unindented, and outputs the following:

ReactDOM.render(
    <Router history={createHistory() }>
        <Route path='/' component={App}>
            <IndexRoute component={SplashView} />
            <Route path='home' component={HomeView} />
            <Route path='chat' component={ChatView} />
            <Route path='/chat/:contact' component={ChatView} />
            </Route>
        </Router>,
    document.getElementById('app')
);

Copied from original issue: microsoft/vscode#985

@saschanaz
Copy link
Contributor

#3838 is related and #4398/#4757 to fix this.

@mhegazy
Copy link
Contributor

mhegazy commented Dec 7, 2015

in dead a duplicate of #3838

@mhegazy mhegazy closed this as completed Dec 7, 2015
@mhegazy mhegazy added the Duplicate An existing issue was already created label Dec 7, 2015
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Duplicate An existing issue was already created
Projects
None yet
Development

No branches or pull requests

3 participants