Unwanted auto-imports in script files

[HolgerJeromin]

Bug Report

I have a mixture of module and non-module code.
The problem occurs when I edit non-module files (tsconfig: "module": "none").

Sometimes when using auto-completion (in VisualStudio 2022) typescript finds a "matching" name from the module world and adds a line like

import { HmiHelper } from './helper/HmiHelper.js';

into the first line of my file.
But as the current file was configured as "module": "none" this import pushes typescript into modules mode and the current code is invalid.

🔎 Search Terms

intellisense
auto-import
modules

🕗 Version & Regression Information

This bug is many years old and persists in Typescript 5.1.

[RyanCavanaugh]

The title seems backwards; do you mean "with module: none" ?

[hardikkoul]

If this is still not resolved or assigned to anyone, may i have a go ?

[HolgerJeromin]

@hardikkoul Just go for it:
https://github.com/Microsoft/TypeScript/blob/main/CONTRIBUTING.md#issue-claiming

Hmm, after rereading the link: This issue do not have a "help wanted" or "Backlog" tag...

[andrewbranch]

@hardikkoul fine by me 👍 There’s a function shouldOfferImportCompletions or something like that in completions.ts.

[hardikkoul]

@HolgerJeromin , @andrewbranch thanks , will start analyzing.

[hardikkoul]

I can see there is a method programContainsModules , so its already checking for module config , but the catch is it only executes when none of the other conditions of shouldOfferImportCompletions return true. Correct me if my understanding is wrong.

[andrewbranch]

You can just add a check that module isn’t none higher up, or change compilerOptionsIndicateEsModules (already a nonsense function, as my old TODO comment notes)

[hardikkoul]

Let me know if it needs any revisions or is totally wrong (which is a possibility :P) , i opted not to touch the existing method just in case something breaks.