Skip to content

Investigate 4.8 perf regression from "Use NonNullable<T> in more scenarios" #49622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
DanielRosenwasser opened this issue Jun 21, 2022 · 0 comments · Fixed by #49760
Closed

Investigate 4.8 perf regression from "Use NonNullable<T> in more scenarios" #49622

DanielRosenwasser opened this issue Jun 21, 2022 · 0 comments · Fixed by #49760
Assignees
@ahejlsberg
Labels
Domain: Performance Reports of unusually slow behavior Fix Available A PR has been opened for this issue Needs Investigation This issue needs a team member to investigate its status.
Milestone
TypeScript 4.8.1

Comments

@DanielRosenwasser
Copy link
Member

#49330 added about 100ms to Compiler-Unions

image

We should investigate the root cause and any mitigations if possible.

Originally posted by @DanielRosenwasser in #49330 (comment)
@DanielRosenwasser DanielRosenwasser added Needs Investigation This issue needs a team member to investigate its status. Domain: Performance Reports of unusually slow behavior labels Jun 21, 2022
@DanielRosenwasser DanielRosenwasser added this to the TypeScript 4.8.1 milestone Jun 21, 2022
@ahejlsberg ahejlsberg mentioned this issue Jul 2, 2022
Merged
@typescript-bot typescript-bot added the Fix Available A PR has been opened for this issue label Jul 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ahejlsberg ahejlsberg

Labels
Domain: Performance Reports of unusually slow behavior Fix Available A PR has been opened for this issue Needs Investigation This issue needs a team member to investigate its status.
Projects
None yet
Milestone
TypeScript 4.8.1
Development

Successfully merging a pull request may close this issue.

Cache results of expensive repetitive type operations microsoft/TypeScript
3 participants
@DanielRosenwasser @ahejlsberg @typescript-bot