Skip to content

Rename of lone identifier in JSX attribute value fails #4404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
RyanCavanaugh opened this issue Aug 21, 2015 · 0 comments
Closed

Rename of lone identifier in JSX attribute value fails #4404

RyanCavanaugh opened this issue Aug 21, 2015 · 0 comments
Assignees
@RyanCavanaugh
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue
Milestone
TypeScript 1.6

Comments

@RyanCavanaugh
Copy link
Member

Fourslash:

//// class MyClass {
////   props: {
////     name?: string;
////     size?: number;
//// }
//// 
//// var [|nn|]: string;
//// var x = <MyClass name={[|n/**/n|]}></MyClass>;

goTo.marker();
verify.renameLocations(false, false);

From #4175
@RyanCavanaugh RyanCavanaugh added the Bug A bug in TypeScript label Aug 21, 2015
@RyanCavanaugh RyanCavanaugh self-assigned this Aug 21, 2015
@RyanCavanaugh RyanCavanaugh added this to the TypeScript 1.6 milestone Aug 21, 2015
@RyanCavanaugh RyanCavanaugh mentioned this issue Aug 21, 2015
Closed
RyanCavanaugh added a commit to RyanCavanaugh/TypeScript that referenced this issue Aug 21, 2015
@RyanCavanaugh
Correctly identify JSX Expressions as Expression parent nodes
00d4b4c 
Fixes bug microsoft#4404
@RyanCavanaugh RyanCavanaugh mentioned this issue Aug 21, 2015
Merged
@RyanCavanaugh RyanCavanaugh added the Fixed A PR has been merged for this issue label Aug 21, 2015
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@RyanCavanaugh RyanCavanaugh

Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue
Projects
None yet
Milestone
TypeScript 1.6
Development

No branches or pull requests
1 participant
@RyanCavanaugh