Skip to content

NewErrors runs have not been running for the past month #43648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
DanielRosenwasser opened this issue Apr 12, 2021 · 5 comments
Closed

NewErrors runs have not been running for the past month #43648

DanielRosenwasser opened this issue Apr 12, 2021 · 5 comments
Assignees
@elibarzilay
Labels
Fixed A PR has been merged for this issue Infrastructure Issue relates to TypeScript team infrastructure
Milestone
TypeScript 4.3.1

Comments

@DanielRosenwasser
Copy link
Member

Our last weekly test on popular repos was on #43004

@amcasey mentioned that a build on chakra-ui isn't cleaning up properly after 10 minutes, which really shouldn't bring the entire weekly test down.
@DanielRosenwasser DanielRosenwasser added the Infrastructure Issue relates to TypeScript team infrastructure label Apr 12, 2021
@DanielRosenwasser DanielRosenwasser changed the title NewErrors runs have not been running for the past month or so NewErrors runs have not been running for the past month Apr 12, 2021
@DanielRosenwasser
Copy link
Member Author

DanielRosenwasser commented Apr 12, 2021 •
edited by amcasey
Loading

This lives internally in the TypeScriptErrorDeltas repo.

Edit: I gave Daniel the wrong repo name. [amcasey]

@DanielRosenwasser DanielRosenwasser added this to the TypeScript 4.3.1 milestone Apr 12, 2021
@DanielRosenwasser
Copy link
Member Author

We should really try to get this fixed soon to ensure nothing regresses before the RC.

@amcasey
Copy link
Member

amcasey commented Apr 12, 2021

Workaround is here. We may wish to continue skipping the problematic repo even after we sort out the timeout issue (looks like the build probably wasn't killed when the timeout was hit).

@elibarzilay elibarzilay added the Fixed A PR has been merged for this issue label May 25, 2021
@elibarzilay
Copy link
Contributor

@DanielRosenwasser: this should have been fixed for a while.
@amcasey: can you confirm that it works so this can be closed?

@amcasey
Copy link
Member

amcasey commented May 25, 2021

Sunday's run LGTM.

@amcasey amcasey closed this as completed May 25, 2021
sandersn pushed a commit to microsoft/typescript-error-deltas that referenced this issue Jan 26, 2022
@amcasey
Work around microsoft/TypeScript#43648
a9e2563
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elibarzilay elibarzilay

Labels
Fixed A PR has been merged for this issue Infrastructure Issue relates to TypeScript team infrastructure
Projects
None yet
Milestone
TypeScript 4.3.1
Development

No branches or pull requests
3 participants
@elibarzilay @DanielRosenwasser @amcasey