Type updates don't propagate in monorepo across package boundaries

[natew]

Steps to Reproduce:

1. In a yarn workspace monorepo, that uses references to build, update a package and it wont update the type definitions anywhere else besides that package.

I was looking for an open issue thinking this would be obvious, but don't see one. It's a huge annoyance working in a mono-repo, it means essentially youre hitting "restart TS server" many times a day.

Apologies if this is already opened.

[mjbvz]

Can you share a small example project or describe your project structure in more detail

[natew]

Yea, sorry for lack of detail here. I actually wonder if this isn't something weirdly specific to me, because I imagine a lot of people would have run into it.

I have a monorepo managed by yarn workspaces. All the packages share a parent tsconfig.base.json and use typescript, here's a typical config:

tsconfig.base.json:

{
  "compilerOptions": {
    "strict": true,
    "incremental": true,
    "declaration": true,
    "declarationMap": true,
    "module": "CommonJS",
    "moduleResolution": "node",
    "esModuleInterop": true,
    "allowSyntheticDefaultImports": true,
    "target": "es2018",
    "noImplicitAny": false,
    "noUnusedLocals": true,
    "noUnusedParameters": true,
    "strictNullChecks": false,
    "strictFunctionTypes": true,
    "preserveConstEnums": true,
    "experimentalDecorators": true,
    "emitDecoratorMetadata": true,
    "jsx": "react",
    "allowJs": false,
    "sourceMap": true,
    "resolveJsonModule": true,
    "lib": ["es2017", "es2018", "dom"]
  },
  "typeAcquisition": {
    "enable": true
  }
}

tsconfig.json

{
  "extends": "../../tsconfig.base",
  "compilerOptions": {
    "composite": true,
    "outDir": "_",
    "rootDir": "src"
  },
  "include": ["src/**/*"],
  "references": [
    { "path": "../../packages/gloss" },
    { "path": "../../packages/use-store" },
    { "path": "../../packages/fast-compare" },
    { "path": "../../packages/ui" },
    { "path": "../models" },
    { "path": "../stores" },
    { "path": "../bridge" }
  ]
}

This is really more of a VSCode issue and I'm realizing I think I used the wrong tab to open this issue, but basically if I make a change to any package, the parents of it won't see the type update in VSCode. But if I go to Restart TS Server it will pick up.

Here's a short video of it.

[domoritz]

This is a big issue for me as well. I use project references and changing code in one project does not update the types for that first project used in another project. I think this is a TS and VSCode issue so it seems okay to file it here.

[domoritz]

Is this a duplicate of #26913?

[natew]

Well it happens with or without references, any symlink module that updates won't get picked up until you restart the typescript server.

Given we use a monorepo and have pretty well-split-up packages, I actually hit cmd+shift+p > restart ts at least 50 times a day 😓

[natew]

More information: I do have watch running inside typescript (Build > tsc: watch) from the root. It compiles everything fine, the types do change in the output directory. If I restart it picks up the changes properly. But it just doesn't look for updates until you do so.

[aleclarson]

Related: The extends property of tsconfig.json is resolved relative to the symlink instead of its real path.

[aleclarson]

Also related: The tsconfig.json of a linked dependency is not used when the main field of the dependency is a *.ts module.

[nilkanthjp]

I've been experiencing this as well for a couple months. Thanks to @natew for the tip on restarting TS server, I've just been restarting VSCode entirely 😂

[chrillewoodz]

Noticing this as well, you can also open the file which contain the updated types and VSC will pick them up. But that is annoying as hell as well.