-
Notifications
You must be signed in to change notification settings - Fork 12.8k
Auto import completion entries still causing debug failure in resolveEntityName, getTargetOfExportAssignment with TS 3.1.3 #28149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Ok, I'm seeing a different stack here than was original reported in #27471 Do these issues have the same root cause? Here's a new stack for reference:
|
Tried 1.28.2 with 3.1.3 default didnt work Tried 1.27.2 with 3.0.3 default worked |
Hi, I was asked to post here. I'm using VS Code 1.28.x and Auto Import is not working. I tried using typescript@next but it did not resolve the issue. |
Same issue as @djensen47 above. Same VSCode version(1.28.2), tried with TS 3.1.3, 3.1.5 and next but Auto import still not working. However, it works when i downgrade TS to 3.0.3. Stack trace: 'getCodeFixes' request failed with error.
Error processing request. Debug Failure.
Error: Debug Failure.
at Object.assertDefined (/usr/share/code/resources/app/extensions/node_modules/typescript/lib/tsserver.js:1446:24)
at getDefaultExportInfoWorker (/usr/share/code/resources/app/extensions/node_modules/typescript/lib/tsserver.js:108210:80)
at getDefaultLikeExportInfo (/usr/share/code/resources/app/extensions/node_modules/typescript/lib/tsserver.js:108191:24)
at /usr/share/code/resources/app/extensions/node_modules/typescript/lib/tsserver.js:108174:35
at /usr/share/code/resources/app/extensions/node_modules/typescript/lib/tsserver.js:108318:21
at forEachExternalModule (/usr/share/code/resources/app/extensions/node_modules/typescript/lib/tsserver.js:108331:21)
at forEachExternalModuleToImportFrom (/usr/share/code/resources/app/extensions/node_modules/typescript/lib/tsserver.js:108316:13)
at getExportInfos (/usr/share/code/resources/app/extensions/node_modules/typescript/lib/tsserver.js:108172:13)
at getFixesInfoForNonUMDImport (/usr/share/code/resources/app/extensions/node_modules/typescript/lib/tsserver.js:108158:57)
at getFixesInfo (/usr/share/code/resources/app/extensions/node_modules/typescript/lib/tsserver.js:108099:50)
at Object.getCodeActions (/usr/share/code/resources/app/extensions/node_modules/typescript/lib/tsserver.js:107861:28)
at /usr/share/code/resources/app/extensions/node_modules/typescript/lib/tsserver.js:106400:121
|
@Andy-MS typescript@next did not solve it. |
@ConneXNL or @gcazaciuc Can you share sample code that reproduces the error? |
I get the following stack trace using typescript 3.2. To trigger:
|
@blikblum Thanks, reproduced it. |
Update: I can reproduce it in |
Howdy! Thanks for your work on this matter so far, I can see you've been battling it for a few months now. Wanted to add to the log that I'm still affected by this as of vscode
And TypeScript version 3.2.1. |
@mjbvz Are you still seeing these errors? @blikblum I tried to follow your repro steps and couldn't find I found a declaration of 'container' in common/di.js by looking at the stack trace, but it doesn't crash anymore for me. Does it still crash for you? |
It did not exists in main.js, to reproduce write yourself "cont" somewhere in main.js and try to invoke auto import. It should add the container import from di module. I'm not with my dev machine. Will try to reproduce ASAP |
@sandersn working fine now (vscode 1.34) |
Uh oh!
There was an error while loading. Please reload this page.
TypeScript Version: 3.1.3
This is reopening #27636 for TS 3.1.3. A few users on VS Code 1.28.2 using TypeScript 3.1.3 still seem to be hitting this: microsoft/vscode#61660, microsoft/vscode#61452
@sandersn @Andy-MS @DanielRosenwasser Can you please just verify that this issued has been fully fixed in 3.1.3. If not, can we try getting the fix in for 3.1.4. I'll follow up with the users on the VS Code side to see if this is fixed in typescript@next
The text was updated successfully, but these errors were encountered: