Skip to content

Update paths on directory rename loses file casing #24968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mjbvz opened this issue Jun 14, 2018 · 1 comment
Closed

Update paths on directory rename loses file casing #24968

mjbvz opened this issue Jun 14, 2018 · 1 comment
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Jun 14, 2018

TypeScript Version: 2.9.2

Search Terms:

  • update import paths
  • rename directory
  • getEditsForFileRename

Code
For a project:

index.ts

import { abc } from './sub/aBc';
console.log(abc)

sub/aBc.ts

export const abc = 123;
  1. Rename sub to sub2

Expected behavior:
index.ts becomes:

import { abc } from './sub2/aBc';
console.log(abc)

Actual behavior:
File casing on aBc lost. index.ts becomes:

import { abc } from './sub2/abc';
console.log(abc)
@mhegazy mhegazy added the Bug A bug in TypeScript label Jun 14, 2018
@mhegazy mhegazy assigned ghost Jun 14, 2018
@mhegazy mhegazy added this to the TypeScript 3.0 milestone Jun 14, 2018
@mjbvz
Copy link
Contributor Author

mjbvz commented Jun 14, 2018

I'm going to add a workaround for this on the VS Code side too since we won't be picking up TS 3.0 this iteration

@ghost ghost added the Fixed A PR has been merged for this issue label Jun 14, 2018
mjbvz added a commit to microsoft/vscode that referenced this issue Jun 15, 2018
@ghost ghost closed this as completed in #24975 Jun 21, 2018
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue
Projects
None yet
Development

No branches or pull requests

2 participants