Skip to content

Duplicate specification of newLineCharacter in RefactorContext #18291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ghost opened this issue Sep 6, 2017 · 2 comments
Closed

Duplicate specification of newLineCharacter in RefactorContext #18291

ghost opened this issue Sep 6, 2017 · 2 comments
Labels
Infrastructure Issue relates to TypeScript team infrastructure

Comments

@ghost
Copy link

ghost commented Sep 6, 2017

TypeScript Version: master

Code

In convertFunctionToEs6Class.ts:

context.rulesProvider.getFormatOptions().newLineCharacter;

RefactorContext already specifies a newLineCharacter direct property; it looks like there are two ways of specifying this that might conflict. @RyanCavanaugh
@ghost ghost added the Infrastructure Issue relates to TypeScript team infrastructure label Sep 6, 2017
@ghost
Copy link
Author

ghost commented Sep 13, 2017

Also, in getRefactorContext in services.ts, we ignore formatOptions.newLineCharacter and call host.getNewLine() instead.

@ghost
Copy link
Author

ghost commented Sep 13, 2017

Also, getEditsForRefactor in client.ts completely ignores formatOptions.

This was referenced Sep 13, 2017
Merged
Merged
Closed
amcasey added a commit to amcasey/TypeScript that referenced this issue Jan 12, 2018
@amcasey
Stop explicitly storing newline in refactoring/code fix contexts
2f2652b 
It's already in the EditorSettings and the LanguageServiceHost.

Fixes microsoft#18291
Fixes microsoft#18445
@amcasey amcasey mentioned this issue Jan 12, 2018
Merged
amcasey added a commit to amcasey/TypeScript that referenced this issue Jan 17, 2018
@amcasey
Stop explicitly storing newline in refactoring/code fix contexts
b4a382b 
It's already in the EditorSettings and the LanguageServiceHost.

Fixes microsoft#18291
Fixes microsoft#18445
@microsoft microsoft locked and limited conversation to collaborators Jul 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Infrastructure Issue relates to TypeScript team infrastructure
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
0 participants