-
Notifications
You must be signed in to change notification settings - Fork 12.8k
esnext features not transpiled within method declarations in object literals with spread elements #16765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
Milestone
Comments
Yogu
added a commit
to Yogu/TypeScript
that referenced
this issue
Jun 27, 2017
Object literal elements that are neither spread elements, nor property assignments would not have visitNode called on them. Therefore, the esnext transformer would not be called on them and their children. Fixes microsoft#16765.
Yogu
added a commit
to Yogu/TypeScript
that referenced
this issue
Jun 27, 2017
Object literal elements that are neither spread elements, nor property assignments would not have visitNode called on them. Therefore, the esnext transformer would not be called on them and their children. Fixes microsoft#16765.
Yogu
added a commit
to Yogu/TypeScript
that referenced
this issue
Jun 27, 2017
Yogu
added a commit
to Yogu/TypeScript
that referenced
this issue
Jun 28, 2017
Object literal elements that are neither spread elements, nor property assignments would not have visitNode called on them. Therefore, the esnext transformer would not be called on them and their children. Fixes microsoft#16765.
Yogu
added a commit
to Yogu/TypeScript
that referenced
this issue
Jun 28, 2017
Yogu
added a commit
to Yogu/TypeScript
that referenced
this issue
Jul 5, 2017
Yogu
added a commit
to Yogu/TypeScript
that referenced
this issue
Aug 13, 2017
Object literal elements that are neither spread elements, nor property assignments would not have visitNode called on them. Therefore, the esnext transformer would not be called on them and their children. Fixes microsoft#16765.
Yogu
added a commit
to Yogu/TypeScript
that referenced
this issue
Aug 13, 2017
I currently can't repro this in |
rbuckton
pushed a commit
that referenced
this issue
Aug 24, 2017
Object literal elements that are neither spread elements, nor property assignments would not have visitNode called on them. Therefore, the esnext transformer would not be called on them and their children. Fixes #16765.
rbuckton
pushed a commit
that referenced
this issue
Aug 24, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Uh oh!
There was an error while loading. Please reload this page.
TypeScript Version: 2.4.0
compilerOptions.target = ES5
Code
Expected behavior:
It compiles and transpiles the object spread operator to a call to
Object.assign
.Actual behavior:
The object spread operator is not transpiled but simply kept. This can lead to the following error:
Problem source:
The esnext transformer cuts off at method declarations within object literals that have an spread element, thus it never sees the inner object literal node.
The text was updated successfully, but these errors were encountered: