TSServer: config file diagnostics event not sent if config file changes

[dbaeumer]

TypeScript Version: 2.0.0
Code
tsconfig.json

{
    "compilerOptions": {
        "module": "commonjs",
        "aaa": 10
    }
}

The server sends and event

Event received: configFileDiag (0).
Data: {
    "triggerFile": "p:/mseng/VSCode/Playgrounds/ts-2.0/test.ts",
    "configFile": "p:/mseng/VSCode/Playgrounds/ts-2.0/tsconfig.json",
    "diagnostics": [
        {
            "text": "Unknown compiler option 'aaa'."
        }
    ]
}

which is correct. Fix the error in the tsconfig.json and save.

Observe: no configFileDiag update is sent. We either need an event to reqeuest configFileDiag or it should automatically happen when the tsconfig.json file is saved and recognized by the server.

[mhegazy]

should be handled by #10418

[mhegazy]

the fix should be in the nightly today

[dbaeumer]

@mhegazy I tested this today with TS 2.0.3 and this is still not working. An error is reported once and even if I change and save the tsconfig.json the errors are not rechecked.

[dbaeumer]

@mhegazy would it be possible to fix this for 2.0.5

[mhegazy]

@zhengbli can you take a look? this should have been fixed already?

[dbaeumer]

@mhegazy sorry for the swirl. Made a mistake during debugging. Will check and and reopen if it is really still an issue.

[dbaeumer]

OK. Now I see. The triggerFile is in that case tsconfig.json which I need to handle differently.

[dbaeumer]

@mhegazy @zhengbli there is still a problem. When an error exist, you fix it and save the tsconfig.json file no notification is sent that no errors exists anymore. The server only sends if errors exists. To clear the error list I need a notification in the no error case as well.

[zhengbli]

I have a fix locally, will send out an PR once the merge between master and release-2.0.5 at #11197 is done so I don't need to repeat that effort.

[dbaeumer]

Please see: #11615

[dbaeumer]

When will this land in 2.0.6 ?

[zhengbli]

This should go with the next release, as it has already been ported to the release branch (release-2.0.5). @mhegazy may know better about the release schedule.

[mhegazy]

We will publish an insider drop today.

[dbaeumer]

I tested this again on 2.0.9 and this is still not working. Here is what I do:

• create a tsconfig.json with an invalid property
• open a TS file which activates the tsconfig.json
• you correctly get an error
• change the wrong property to another invalid property name

Observe: you don't get an event informing you about the new invalid property name

• change the property name to a valid property name

Observe: you don't get an event informing you that no error exists

[dbaeumer]

@mhegazy @zhengbli can you please have a look

[dbaeumer]

If you close and reopen the TS file then the tsconfig.json gets revalidated.

[zhengbli]

This should be fixed in master now, @dbaeumer can you give it a try? thanks

[alex-kinokon]

Is this supposed to land in 2.1?

[dbaeumer]

@mjbvz can you have a look. To test it when this lands in 2.1.3 you need to uncomment the code here: https://github.com/Microsoft/vscode/blob/master/extensions/typescript/src/typescriptMain.ts#L374