Some more refactoring for handling background projects

Author: sheetalkamat

src/server/editorServices.ts

@@ -154,6 +154,7 @@ import {
     hasNoTypeScriptSource,
     InferredProject,
     InvalidateCachedTypings,
+    isBackgroundProject,
     isConfiguredProject,
     isDynamicFileName,
     isInferredProject,
@@ -1326,15 +1327,14 @@ export class ProjectService {
 
     private delayUpdateProjectGraph(project: Project) {
         project.markAsDirty();
-        if (project.projectKind !== ProjectKind.AutoImportProvider && project.projectKind !== ProjectKind.Auxiliary) {
-            const projectName = project.getProjectName();
-            this.pendingProjectUpdates.set(projectName, project);
-            this.throttledOperations.schedule(projectName, /*delay*/ 250, () => {
-                if (this.pendingProjectUpdates.delete(projectName)) {
-                    updateProjectIfDirty(project);
-                }
-            });
-        }
+        if (isBackgroundProject(project)) return;
+        const projectName = project.getProjectName();
+        this.pendingProjectUpdates.set(projectName, project);
+        this.throttledOperations.schedule(projectName, /*delay*/ 250, () => {
+            if (this.pendingProjectUpdates.delete(projectName)) {
+                updateProjectIfDirty(project);
+            }
+        });
     }
 
     /** @internal */

src/server/project.ts

@@ -579,7 +579,7 @@ export abstract class Project implements LanguageServiceHost, ModuleResolutionHo
             this.disableLanguageService(lastFileExceededProgramSize);
         }
         this.markAsDirty();
-        if (projectKind !== ProjectKind.AutoImportProvider) {
+        if (!isBackgroundProject(this)) {
             this.projectService.pendingEnsureProjectForOpenFiles = true;
         }
     }
@@ -2996,3 +2996,8 @@ export function isConfiguredProject(project: Project): project is ConfiguredProj
 export function isExternalProject(project: Project): project is ExternalProject {
     return project.projectKind === ProjectKind.External;
 }
+
+/**@internal */
+export function isBackgroundProject(project: Project): project is AutoImportProviderProject | AuxiliaryProject {
+    return project.projectKind === ProjectKind.AutoImportProvider || project.projectKind === ProjectKind.Auxiliary;
+}

src/server/scriptInfo.ts

@@ -40,13 +40,13 @@ import {
     Errors,
     ExternalProject,
     InferredProject,
+    isBackgroundProject,
     isConfiguredProject,
     isExternalProject,
     isInferredProject,
     maxFileSize,
     NormalizedPath,
     Project,
-    ProjectKind,
     ScriptVersionCache,
     ServerHost,
 } from "./_namespaces/ts.server";
@@ -682,7 +682,7 @@ export class ScriptInfo {
     isContainedByBackgroundProject() {
         return some(
             this.containingProjects,
-            p => p.projectKind === ProjectKind.AutoImportProvider || p.projectKind === ProjectKind.Auxiliary,
+            isBackgroundProject,
         );
     }
 
@@ -730,7 +730,7 @@ export class ScriptInfo {
  * reported as the default project for a ScriptInfo.
  */
 function ensurePrimaryProjectKind(project: Project | undefined) {
-    if (!project || project.projectKind === ProjectKind.AutoImportProvider || project.projectKind === ProjectKind.Auxiliary) {
+    if (!project || isBackgroundProject(project)) {
         return Errors.ThrowNoProject();
     }
     return project;