Skip to content

Commit bdd8a3e

Browse files
committed
Only add "Did you forget await" for function args when the parameter type is not promise-like
1 parent 6450199 commit bdd8a3e

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

src/compiler/checker.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21453,6 +21453,10 @@ namespace ts {
2145321453

2145421454
function maybeAddMissingAwaitInfo(errorNode: Node | undefined, source: Type, target: Type) {
2145521455
if (errorNode && reportErrors && errorOutputContainer.errors && errorOutputContainer.errors.length) {
21456+
// Bail if target is Promise-like---something else is wrong
21457+
if (getAwaitedTypeOfPromise(target)) {
21458+
return;
21459+
}
2145621460
const awaitedTypeOfSource = getAwaitedTypeOfPromise(source);
2145721461
if (awaitedTypeOfSource && isTypeRelatedTo(awaitedTypeOfSource, target, relation)) {
2145821462
addRelatedInfo(errorOutputContainer.errors[0], createDiagnosticForNode(errorNode, Diagnostics.Did_you_forget_to_use_await));

0 commit comments

Comments
 (0)