Don’t allow an object literal with a spread as a fallback for destructuring a property not present in all constituents (#43783)

* Add test

* Don’t allow an object literal with a spread as a fallback for destructuring a property not present in all constituents

Author: andrewbranch

src/compiler/checker.ts

@@ -11698,7 +11698,7 @@ namespace ts {
                             checkFlags |= CheckFlags.WritePartial | (indexInfo.isReadonly ? CheckFlags.Readonly : 0);
                             indexTypes = append(indexTypes, isTupleType(type) ? getRestTypeOfTupleType(type) || undefinedType : indexInfo.type);
                         }
-                        else if (isObjectLiteralType(type)) {
+                        else if (isObjectLiteralType(type) && !(getObjectFlags(type) & ObjectFlags.ContainsSpread)) {
                             checkFlags |= CheckFlags.WritePartial;
                             indexTypes = append(indexTypes, undefinedType);
                         }

tests/baselines/reference/destructuringFromUnionSpread.errors.txt

@@ -0,0 +1,12 @@
+tests/cases/compiler/destructuringFromUnionSpread.ts(5,9): error TS2525: Initializer provides no value for this binding element and the binding element has no default value.
+
+
+==== tests/cases/compiler/destructuringFromUnionSpread.ts (1 errors) ====
+    interface A { a: string }
+    interface B { b: number }
+    
+    declare const x: A | B;
+    const { a } = { ...x } // error
+            ~
+!!! error TS2525: Initializer provides no value for this binding element and the binding element has no default value.
+    

tests/baselines/reference/destructuringFromUnionSpread.js

@@ -0,0 +1,21 @@
+//// [destructuringFromUnionSpread.ts]
+interface A { a: string }
+interface B { b: number }
+
+declare const x: A | B;
+const { a } = { ...x } // error
+
+
+//// [destructuringFromUnionSpread.js]
+var __assign = (this && this.__assign) || function () {
+    __assign = Object.assign || function(t) {
+        for (var s, i = 1, n = arguments.length; i < n; i++) {
+            s = arguments[i];
+            for (var p in s) if (Object.prototype.hasOwnProperty.call(s, p))
+                t[p] = s[p];
+        }
+        return t;
+    };
+    return __assign.apply(this, arguments);
+};
+var a = __assign({}, x).a; // error

tests/baselines/reference/destructuringFromUnionSpread.symbols

@@ -0,0 +1,18 @@
+=== tests/cases/compiler/destructuringFromUnionSpread.ts ===
+interface A { a: string }
+>A : Symbol(A, Decl(destructuringFromUnionSpread.ts, 0, 0))
+>a : Symbol(A.a, Decl(destructuringFromUnionSpread.ts, 0, 13))
+
+interface B { b: number }
+>B : Symbol(B, Decl(destructuringFromUnionSpread.ts, 0, 25))
+>b : Symbol(B.b, Decl(destructuringFromUnionSpread.ts, 1, 13))
+
+declare const x: A | B;
+>x : Symbol(x, Decl(destructuringFromUnionSpread.ts, 3, 13))
+>A : Symbol(A, Decl(destructuringFromUnionSpread.ts, 0, 0))
+>B : Symbol(B, Decl(destructuringFromUnionSpread.ts, 0, 25))
+
+const { a } = { ...x } // error
+>a : Symbol(a, Decl(destructuringFromUnionSpread.ts, 4, 7))
+>x : Symbol(x, Decl(destructuringFromUnionSpread.ts, 3, 13))
+

tests/baselines/reference/destructuringFromUnionSpread.types

@@ -0,0 +1,15 @@
+=== tests/cases/compiler/destructuringFromUnionSpread.ts ===
+interface A { a: string }
+>a : string
+
+interface B { b: number }
+>b : number
+
+declare const x: A | B;
+>x : A | B
+
+const { a } = { ...x } // error
+>a : any
+>{ ...x } : { a: any; } | { a: any; b: number; }
+>x : A | B
+

tests/cases/compiler/destructuringFromUnionSpread.ts

@@ -0,0 +1,5 @@
+interface A { a: string }
+interface B { b: number }
+
+declare const x: A | B;
+const { a } = { ...x } // error