Only add suggestion for modules

Author: Andy Hanson

src/services/suggestionDiagnostics.ts

@@ -32,7 +32,7 @@ namespace ts {
         }
         check(sourceFile);
 
-        if (!isJsFile) {
+        if (!isJsFile && sourceFile.externalModuleIndicator) {
             for (const statement of sourceFile.statements) {
                 if (isVariableStatement(statement) &&
                     statement.declarationList.flags & NodeFlags.Const &&

tests/cases/fourslash/codeFixRequireInTs.ts

@@ -1,7 +1,8 @@
 /// <reference path='fourslash.ts' />
 
-// @Filename: /a.ts
+////export {};
 ////const a = [|require("a")|];
+////a;
 
 verify.getSuggestionDiagnostics([{
     message: "'require' call may be converted to an import.",
@@ -11,5 +12,8 @@ verify.getSuggestionDiagnostics([{
 verify.codeFix({
     description: "Convert 'require' to 'import'",
     newFileContent:
-`import a = require("a");`,
+// TODO: GH#23781
+`export {};
+    import a = require("a");
+a;`,
 });

tests/cases/fourslash/codeFixRequireInTs_all.ts

@@ -1,13 +1,15 @@
 /// <reference path='fourslash.ts' />
 
-// @Filename: /a.ts
+////export {};
 ////const a = [|require("a")|];
 ////const b = [|require("b")|];
 
 verify.codeFixAll({
     fixId: "requireInTs",
     fixAllDescription: "Convert all 'require' to 'import'",
     newFileContent:
-`import a = require("a");
+// TODO: GH#23781
+`export {};
+    import a = require("a");
 import b = require("b");`,
 });

tests/cases/fourslash/codeFixRequireInTs_allowSyntheticDefaultImports.ts

@@ -2,10 +2,15 @@
 
 // @allowSyntheticDefaultImports: true
 
-// @Filename: /a.ts
+////export {};
 ////const a = [|require("a")|];
+////a;
 
 verify.codeFix({
     description: "Convert 'require' to 'import'",
-    newFileContent: `import a from "a";`,
+    newFileContent:
+// TODO: GH#23781
+`export {};
+    import a from "a";
+a;`,
 });

tests/cases/fourslash/codeFixRequireInTs_onlyIfModule.ts

@@ -0,0 +1,5 @@
+/// <reference path='fourslash.ts' />
+
+////const a = [|require("a")|];
+
+verify.getSuggestionDiagnostics([]);