Resolve a todo

jakebailey · jakebailey · commit 9a70c299da28 · 2023-07-27T17:33:26.000-07:00
diff --git a/src/compiler/utilities.ts b/src/compiler/utilities.ts
@@ -8110,9 +8110,8 @@ export function setObjectAllocator(alloc: ObjectAllocator) {
     forEach(objectAllocatorPatchers, fn => fn(objectAllocator));
 }
 
-// TODO(jakebailey): replace args type with DiagnosticArguments
 /** @internal */
-export function formatStringFromArgs(text: string, args: ArrayLike<string | number>): string {
+export function formatStringFromArgs(text: string, args: DiagnosticArguments): string {
     return text.replace(/{(\d+)}/g, (_match, index: string) => "" + Debug.checkDefined(args[+index]));
 }
 

Original file line number	Diff line number	Diff line change
`@@ -8110,9 +8110,8 @@ export function setObjectAllocator(alloc: ObjectAllocator) {`
`8110`	`8110`	`forEach(objectAllocatorPatchers, fn => fn(objectAllocator));`
`8111`	`8111`	`}`
`8112`	`8112`
`8113`		`-// TODO(jakebailey): replace args type with DiagnosticArguments`
`8114`	`8113`	`/** @internal */`
`8115`		`-export function formatStringFromArgs(text: string, args: ArrayLike<string \| number>): string {`
	`8114`	`+export function formatStringFromArgs(text: string, args: DiagnosticArguments): string {`
`8116`	`8115`	`return text.replace(/{(\d+)}/g, (_match, index: string) => "" + Debug.checkDefined(args[+index]));`
`8117`	`8116`	`}`
`8118`	`8117`