Skip to content

Commit 7c1df15

Browse files
authored
Merge pull request #9556 from weswigham/import-q
Swap q from a reference to an import
2 parents e1c69d7 + f9102d0 commit 7c1df15

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

Gulpfile.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,4 @@
11
/// <reference path="scripts/types/ambient.d.ts" />
2-
/// <reference types="q" />
3-
42
import * as cp from "child_process";
53
import * as path from "path";
64
import * as fs from "fs";
@@ -20,9 +18,9 @@ declare module "gulp-typescript" {
2018
}
2119
import * as insert from "gulp-insert";
2220
import * as sourcemaps from "gulp-sourcemaps";
21+
import Q = require("q");
2322
declare global {
24-
// This is silly. We include Q because orchestrator (a part of gulp) depends on it, but its not included.
25-
// `del` further depends on `Promise` (and is also not included), so we just, patch the global scope's Promise to Q's
23+
// `del` further depends on `Promise` (and is also not included), so we just, patch the global scope's Promise to Q's (which we already include in our deps because gulp depends on it)
2624
type Promise<T> = Q.Promise<T>;
2725
}
2826
import del = require("del");

0 commit comments

Comments
 (0)