Merge branch 'main' into typeof-coud-narrow-union-type

Author: ShuiRuTian

.github/workflow-resources/.lsifrc.json

@@ -0,0 +1,6 @@
+{
+	"project": "../../src/tsconfig.json",
+	"source": "../../package.json",
+	"package": "../../package.json",
+	"out": "../../typescript.lsif"
+}

.github/workflows/rich-navigation.yml

@@ -0,0 +1,35 @@
+name: "Rich Navigation Indexing"
+on:
+  workflow_dispatch:
+  push:
+    branches:
+      - main
+      - release-*
+  pull_request:
+    branches:
+      - main
+      - release-*
+
+jobs:
+  richnav:
+    runs-on: windows-latest
+
+    steps:
+      - uses: actions/checkout@v2
+        with:
+          fetch-depth: 5
+
+      - uses: actions/setup-node@v2
+        with:
+          node-version: 14
+
+      - name: Install dependencies
+        run:  npm ci
+
+      - uses: microsoft/[email protected]
+        with:
+          languages: typescript
+          repo-token: ${{ secrets.GITHUB_TOKEN }}
+          typescriptVersion: 0.6.0-next.18
+          configFiles: .github/workflow-resources/.lsifrc.json
+        continue-on-error: true

CONTRIBUTING.md

@@ -72,7 +72,7 @@ In general, things we find useful when reviewing suggestions are:
 
 ### Using a development container
 
-This repository includes a [development container](https://code.visualstudio.com/docs/remote/containers) that you can use to quickly create an isolated development environment with all the tools you need to start working on TypeScript. To get started with a dev container and VS Code, either:
+If you prefer to develop using containers, this repository includes a [development container](https://code.visualstudio.com/docs/remote/containers) that you can use to quickly create an isolated development environment with all the tools you need to start working on TypeScript. To get started with a dev container and VS Code, either:
 
 - Clone the TypeScript repository locally and use the `Open Folder in Container` command.
 - Use the `Clone Repository in Container Volume` command to clone the TypeScript repository into a new container.

Gulpfile.js

@@ -437,10 +437,6 @@ task("watch-local").flags = {
     "   --built": "Compile using the built version of the compiler."
 };
 
-const generateCodeCoverage = () => exec("istanbul", ["cover", "node_modules/mocha/bin/_mocha", "--", "-R", "min", "-t", "" + cmdLineOptions.testTimeout, "built/local/run.js"]);
-task("generate-code-coverage", series(preBuild, buildTests, generateCodeCoverage));
-task("generate-code-coverage").description = "Generates code coverage data via istanbul";
-
 const preTest = parallel(buildTsc, buildTests, buildServices, buildLssl);
 preTest.displayName = "preTest";
 

lib/lib.es2021.d.ts

@@ -22,3 +22,4 @@ and limitations under the License.
 /// <reference lib="es2021.promise" />
 /// <reference lib="es2021.string" />
 /// <reference lib="es2021.weakref" />
+/// <reference lib="es2021.intl" />

package-lock.json

@@ -34,7 +34,7 @@
         "@types/chai": "latest",
         "@types/convert-source-map": "latest",
         "@types/glob": "latest",
-        "@types/gulp": "^4.0.5",
+        "@types/gulp": "^4.0.9",
         "@types/gulp-concat": "latest",
         "@types/gulp-newer": "latest",
         "@types/gulp-rename": "0.0.33",
@@ -57,7 +57,7 @@
         "@typescript-eslint/experimental-utils": "^4.28.0",
         "@typescript-eslint/parser": "^4.28.0",
         "async": "latest",
-        "azure-devops-node-api": "^10.1.0",
+        "azure-devops-node-api": "^11.0.1",
         "browser-resolve": "^1.11.2",
         "browserify": "latest",
         "chai": "latest",
@@ -79,19 +79,17 @@
         "gulp-newer": "latest",
         "gulp-rename": "latest",
         "gulp-sourcemaps": "latest",
-        "istanbul": "latest",
         "merge2": "latest",
         "minimist": "latest",
         "mkdirp": "latest",
         "mocha": "latest",
         "mocha-fivemat-progress-reporter": "latest",
         "ms": "latest",
-        "node-fetch": "^2.6.0",
+        "node-fetch": "^2.6.1",
         "plugin-error": "latest",
         "pretty-hrtime": "^1.0.3",
         "prex": "^0.4.3",
         "q": "latest",
-        "remove-internal": "^2.9.2",
         "source-map-support": "latest",
         "through2": "latest",
         "typescript": "^4.2.3",

package.json

@@ -0,0 +1,30 @@
+// @ts-check
+// This file requires a modern version of node 14+, and grep to be available.
+
+// node scripts/find-unused-diagnostic-messages.mjs
+import { readFileSync } from "fs";
+import {EOL} from "os";
+import { execSync } from "child_process";
+
+const diags = readFileSync("src/compiler/diagnosticInformationMap.generated.ts", "utf8");
+const startOfDiags = diags.split("export const Diagnostics")[1];
+
+const missingNames = [];
+startOfDiags.split(EOL).forEach(line => {
+    if (!line.includes(":")) return;
+    const diagName = line.split(":")[0].trim();
+
+    try {
+        execSync(`grep -rnw 'src' -e 'Diagnostics.${diagName}'`).toString();
+        process.stdout.write(".");
+    } catch (error) {
+        missingNames.push(diagName);
+        process.stdout.write("x");
+    }
+});
+
+if (missingNames.length) {
+    process.exitCode = 1;
+    console.log("Could not find usage of these diagnostics in the codebase:");
+    console.log(missingNames);
+}

scripts/find-unused-diganostic-messages.mjs

@@ -3388,7 +3388,7 @@ namespace ts {
 
         function bindTypeParameter(node: TypeParameterDeclaration) {
             if (isJSDocTemplateTag(node.parent)) {
-                const container = find((node.parent.parent as JSDoc).tags!, isJSDocTypeAlias) || getHostSignatureFromJSDoc(node.parent); // TODO: GH#18217
+                const container = getEffectiveContainerForJSDocTemplateTag(node.parent);
                 if (container) {
                     if (!container.locals) {
                         container.locals = createSymbolTable();