Check declaration modifier, not class modifier

JoshuaKGoldberg · JoshuaKGoldberg · commit 67a940bbaad8 · 2022-12-15T20:12:16.000-05:00
diff --git a/src/services/codefixes/helpers.ts b/src/services/codefixes/helpers.ts
@@ -322,13 +322,7 @@ export function addNewNodeForMemberSymbol(
     }
 
     function shouldAddOverrideKeyword(): boolean {
-        if (!context.program.getCompilerOptions().noImplicitOverride || !enclosingDeclaration.heritageClauses) {
-            return false;
-        }
-
-        const valueDeclaration = checker.getSymbolAtLocation(enclosingDeclaration.heritageClauses[0].types[0].expression)?.valueDeclaration;
-
-        return !!(valueDeclaration && hasAbstractModifier(valueDeclaration));
+        return !!(context.program.getCompilerOptions().noImplicitOverride && declaration && hasAbstractModifier(declaration));
     }
 
     function createName(node: PropertyName) {

Original file line number	Diff line number	Diff line change
`@@ -322,13 +322,7 @@ export function addNewNodeForMemberSymbol(`
`322`	`322`	`}`
`323`	`323`
`324`	`324`	`function shouldAddOverrideKeyword(): boolean {`
`325`		`- if (!context.program.getCompilerOptions().noImplicitOverride \|\| !enclosingDeclaration.heritageClauses) {`
`326`		`- return false;`
`327`		`- }`
`328`		`-`
`329`		`- const valueDeclaration = checker.getSymbolAtLocation(enclosingDeclaration.heritageClauses[0].types[0].expression)?.valueDeclaration;`
`330`		`-`
`331`		`- return !!(valueDeclaration && hasAbstractModifier(valueDeclaration));`
	`325`	`+ return !!(context.program.getCompilerOptions().noImplicitOverride && declaration && hasAbstractModifier(declaration));`
`332`	`326`	`}`
`333`	`327`
`334`	`328`	`function createName(node: PropertyName) {`