Rename SyntaxKind.Parameter to SyntaxKind.ParameterDeclaration

Author: jakebailey

src/compiler/binder.ts

@@ -734,7 +734,7 @@ function createBinder(): (file: SourceFile, options: CompilerOptions) => void {
                 break;
             case SyntaxKind.JSDocFunctionType:
                 return (isJSDocConstructSignature(node) ? InternalSymbolName.New : InternalSymbolName.Call);
-            case SyntaxKind.Parameter:
+            case SyntaxKind.ParameterDeclaration:
                 // Parameters with names are handled at the top of this function.  Parameters
                 // without names can only come from JSDocFunctionTypes.
                 Debug.assert(node.parent.kind === SyntaxKind.JSDocFunctionType, "Impossible parameter parent kind", () => `parent is: ${Debug.formatSyntaxKind(node.parent.kind)}, expected JSDocFunctionType`);
@@ -1206,7 +1206,7 @@ function createBinder(): (file: SourceFile, options: CompilerOptions) => void {
             case SyntaxKind.BindingElement:
                 bindBindingElementFlow(node as BindingElement);
                 break;
-            case SyntaxKind.Parameter:
+            case SyntaxKind.ParameterDeclaration:
                 bindParameterFlow(node as ParameterDeclaration);
                 break;
             case SyntaxKind.ObjectLiteralExpression:
@@ -2940,7 +2940,7 @@ function createBinder(): (file: SourceFile, options: CompilerOptions) => void {
                 break; // Binding the children will handle everything
             case SyntaxKind.TypeParameter:
                 return bindTypeParameter(node as TypeParameterDeclaration);
-            case SyntaxKind.Parameter:
+            case SyntaxKind.ParameterDeclaration:
                 return bindParameter(node as ParameterDeclaration);
             case SyntaxKind.VariableDeclaration:
                 return bindVariableDeclarationOrBindingElement(node as VariableDeclaration);

src/compiler/checker.ts

@@ -1577,7 +1577,7 @@ export function createPrinter(printerOptions: PrinterOptions = {}, handlers: Pri
                 // Signature elements
                 case SyntaxKind.TypeParameter:
                     return emitTypeParameter(node as TypeParameterDeclaration);
-                case SyntaxKind.Parameter:
+                case SyntaxKind.ParameterDeclaration:
                     return emitParameter(node as ParameterDeclaration);
                 case SyntaxKind.Decorator:
                     return emitDecorator(node as Decorator);
@@ -5298,7 +5298,7 @@ export function createPrinter(printerOptions: PrinterOptions = {}, handlers: Pri
                 forEach((node as VariableDeclarationList).declarations, generateNames);
                 break;
             case SyntaxKind.VariableDeclaration:
-            case SyntaxKind.Parameter:
+            case SyntaxKind.ParameterDeclaration:
             case SyntaxKind.BindingElement:
             case SyntaxKind.ClassDeclaration:
                 generateNameIfNeeded((node as NamedDeclaration).name);

src/compiler/emitter.ts

@@ -89,7 +89,7 @@ export function createSyntacticTypeNodeBuilder(
         switch (node.kind) {
             case SyntaxKind.PropertySignature:
                 return serializeExistingTypeAnnotation(getEffectiveTypeAnnotationNode(node));
-            case SyntaxKind.Parameter:
+            case SyntaxKind.ParameterDeclaration:
                 return typeFromParameter(node, context);
             case SyntaxKind.VariableDeclaration:
                 return typeFromVariable(node, context);

src/compiler/expressionToTypeNode.ts

@@ -1649,7 +1649,7 @@ export function createNodeFactory(flags: NodeFactoryFlags, baseFactory: BaseNode
         type?: TypeNode,
         initializer?: Expression,
     ) {
-        const node = createBaseDeclaration<ParameterDeclaration>(SyntaxKind.Parameter);
+        const node = createBaseDeclaration<ParameterDeclaration>(SyntaxKind.ParameterDeclaration);
         node.modifiers = asNodeArray(modifiers);
         node.dotDotDotToken = dotDotDotToken;
         node.name = asName(name);
@@ -7321,7 +7321,7 @@ function getTransformFlagsSubtreeExclusions(kind: SyntaxKind) {
             return TransformFlags.ArrayLiteralOrCallOrNewExcludes;
         case SyntaxKind.ModuleDeclaration:
             return TransformFlags.ModuleExcludes;
-        case SyntaxKind.Parameter:
+        case SyntaxKind.ParameterDeclaration:
             return TransformFlags.ParameterExcludes;
         case SyntaxKind.ArrowFunction:
             return TransformFlags.ArrowFunctionExcludes;

src/compiler/factory/nodeFactory.ts

@@ -405,7 +405,7 @@ export function isTypeParameterDeclaration(node: Node): node is TypeParameterDec
 }
 
 export function isParameterDeclaration(node: Node): node is ParameterDeclaration {
-    return node.kind === SyntaxKind.Parameter;
+    return node.kind === SyntaxKind.ParameterDeclaration;
 }
 
 export function isDecorator(node: Node): node is Decorator {

src/compiler/factory/nodeTests.ts

@@ -984,7 +984,7 @@ export function getTargetOfBindingOrAssignmentElement(bindingElement: BindingOrA
  */
 export function getRestIndicatorOfBindingOrAssignmentElement(bindingElement: BindingOrAssignmentElement): BindingOrAssignmentElementRestIndicator | undefined {
     switch (bindingElement.kind) {
-        case SyntaxKind.Parameter:
+        case SyntaxKind.ParameterDeclaration:
         case SyntaxKind.BindingElement:
             // `...` in `let [...a] = ...`
             return bindingElement.dotDotDotToken;

src/compiler/factory/utilities.ts

@@ -14,7 +14,7 @@ export function setTextRange<T extends TextRange>(range: T, location: TextRange
 export function canHaveModifiers(node: Node): node is HasModifiers {
     const kind = node.kind;
     return kind === SyntaxKind.TypeParameter
-        || kind === SyntaxKind.Parameter
+        || kind === SyntaxKind.ParameterDeclaration
         || kind === SyntaxKind.PropertySignature
         || kind === SyntaxKind.PropertyDeclaration
         || kind === SyntaxKind.MethodSignature
@@ -42,7 +42,7 @@ export function canHaveModifiers(node: Node): node is HasModifiers {
 
 export function canHaveDecorators(node: Node): node is HasDecorators {
     const kind = node.kind;
-    return kind === SyntaxKind.Parameter
+    return kind === SyntaxKind.ParameterDeclaration
         || kind === SyntaxKind.PropertyDeclaration
         || kind === SyntaxKind.MethodDeclaration
         || kind === SyntaxKind.GetAccessor

src/compiler/factory/utilitiesPublic.ts

@@ -524,7 +524,7 @@ const forEachChildTable: ForEachChildTable = {
     [SyntaxKind.SpreadAssignment]: function forEachChildInSpreadAssignment<T>(node: SpreadAssignment, cbNode: (node: Node) => T | undefined, _cbNodes?: (nodes: NodeArray<Node>) => T | undefined): T | undefined {
         return visitNode(cbNode, node.expression);
     },
-    [SyntaxKind.Parameter]: function forEachChildInParameter<T>(node: ParameterDeclaration, cbNode: (node: Node) => T | undefined, cbNodes?: (nodes: NodeArray<Node>) => T | undefined): T | undefined {
+    [SyntaxKind.ParameterDeclaration]: function forEachChildInParameter<T>(node: ParameterDeclaration, cbNode: (node: Node) => T | undefined, cbNodes?: (nodes: NodeArray<Node>) => T | undefined): T | undefined {
         return visitNodes(cbNode, cbNodes, node.modifiers) ||
             visitNode(cbNode, node.dotDotDotToken) ||
             visitNode(cbNode, node.name) ||
@@ -3389,7 +3389,7 @@ namespace Parser {
     }
 
     function isReusableParameter(node: Node) {
-        if (node.kind !== SyntaxKind.Parameter) {
+        if (node.kind !== SyntaxKind.ParameterDeclaration) {
             return false;
         }
 

src/compiler/parser.ts

@@ -3147,7 +3147,7 @@ export function createProgram(rootNamesOrOptions: readonly string[] | CreateProg
                 // Otherwise break to visit each child
 
                 switch (parent.kind) {
-                    case SyntaxKind.Parameter:
+                    case SyntaxKind.ParameterDeclaration:
                     case SyntaxKind.PropertyDeclaration:
                     case SyntaxKind.MethodDeclaration:
                         if ((parent as ParameterDeclaration | PropertyDeclaration | MethodDeclaration).questionToken === node) {
@@ -3321,7 +3321,7 @@ export function createProgram(rootNamesOrOptions: readonly string[] | CreateProg
                             return "skip";
                         }
                         break;
-                    case SyntaxKind.Parameter:
+                    case SyntaxKind.ParameterDeclaration:
                         // Check modifiers of parameter declaration
                         if (nodes === (parent as ParameterDeclaration).modifiers && some(nodes, isModifier)) {
                             diagnostics.push(createDiagnosticForNodeArray(nodes, Diagnostics.Parameter_modifiers_can_only_be_used_in_TypeScript_files));