Skip to content

Commit 5313604

Browse files
committed
Cleanup blocking calls
1 parent 9923102 commit 5313604

File tree

1 file changed

+3
-6
lines changed

1 file changed

+3
-6
lines changed

src/compiler/checker.ts

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1636,7 +1636,7 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
16361636
getResolvedSignature: (node, candidatesOutArray, argumentCount) =>
16371637
getResolvedSignatureWorker(node, candidatesOutArray, argumentCount, CheckMode.Normal),
16381638
getResolvedSignatureForStringLiteralCompletions: (call, editingArgument, candidatesOutArray) =>
1639-
runWithoutResolvedSignatureCaching(call, () => getResolvedSignatureWorker(call, candidatesOutArray, /*argumentCount*/ undefined, CheckMode.IsForStringLiteralArgumentCompletions, editingArgument)),
1639+
runWithInferenceBlockedFromSourceNode(editingArgument, () => getResolvedSignatureWorker(call, candidatesOutArray, /*argumentCount*/ undefined, CheckMode.IsForStringLiteralArgumentCompletions)),
16401640
getResolvedSignatureForSignatureHelp: (node, candidatesOutArray, argumentCount) =>
16411641
runWithoutResolvedSignatureCaching(node, () => getResolvedSignatureWorker(node, candidatesOutArray, argumentCount, CheckMode.IsForSignatureHelp)),
16421642
getExpandedParameters,
@@ -1846,13 +1846,10 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
18461846
return result;
18471847
}
18481848

1849-
function getResolvedSignatureWorker(nodeIn: CallLikeExpression, candidatesOutArray: Signature[] | undefined, argumentCount: number | undefined, checkMode: CheckMode, editingArgument?: Node): Signature | undefined {
1849+
function getResolvedSignatureWorker(nodeIn: CallLikeExpression, candidatesOutArray: Signature[] | undefined, argumentCount: number | undefined, checkMode: CheckMode): Signature | undefined {
18501850
const node = getParseTreeNode(nodeIn, isCallLikeExpression);
18511851
apparentArgumentCount = argumentCount;
1852-
const res =
1853-
!node ? undefined :
1854-
editingArgument ? runWithInferenceBlockedFromSourceNode(editingArgument, () => getResolvedSignature(node, candidatesOutArray, checkMode)) :
1855-
getResolvedSignature(node, candidatesOutArray, checkMode);
1852+
const res = !node ? undefined : getResolvedSignature(node, candidatesOutArray, checkMode);
18561853
apparentArgumentCount = undefined;
18571854
return res;
18581855
}

0 commit comments

Comments
 (0)