Report excess property errors on object literal names (#53129)

Author: Andarist

src/compiler/checker.ts

@@ -20711,9 +20711,9 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
                                     const propDeclaration = prop.valueDeclaration as ObjectLiteralElementLike;
                                     Debug.assertNode(propDeclaration, isObjectLiteralElementLike);
 
-                                    errorNode = propDeclaration;
-
                                     const name = propDeclaration.name!;
+                                    errorNode = name;
+
                                     if (isIdentifier(name)) {
                                         suggestion = getSuggestionForNonexistentProperty(name, errorTarget);
                                     }

tests/baselines/reference/arrayCast.errors.txt

@@ -7,7 +7,7 @@ tests/cases/compiler/arrayCast.ts(3,23): error TS2352: Conversion of type '{ foo
     // Should fail. Even though the array is contextually typed with { id: number }[], it still
     // has type { foo: string }[], which is not assignable to { id: number }[].
     <{ id: number; }[]>[{ foo: "s" }];
-                          ~~~~~~~~
+                          ~~~
 !!! error TS2352: Conversion of type '{ foo: string; }[]' to type '{ id: number; }[]' may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to 'unknown' first.
 !!! error TS2352:   Type '{ foo: string; }' is not comparable to type '{ id: number; }'.
 !!! error TS2352:     Object literal may only specify known properties, and 'foo' does not exist in type '{ id: number; }'.

tests/baselines/reference/arrayLiteralTypeInference.errors.txt

@@ -23,11 +23,11 @@ tests/cases/compiler/arrayLiteralTypeInference.ts(32,18): error TS2322: Type '{
 
     var x1: Action[] = [
         { id: 2, trueness: false },
-                 ~~~~~~~~~~~~~~~
+                 ~~~~~~~~
 !!! error TS2322: Type '{ id: number; trueness: false; }' is not assignable to type 'Action'.
 !!! error TS2322:   Object literal may only specify known properties, and 'trueness' does not exist in type 'Action'.
         { id: 3, name: "three" }
-                 ~~~~~~~~~~~~~
+                 ~~~~
 !!! error TS2322: Type '{ id: number; name: string; }' is not assignable to type 'Action'.
 !!! error TS2322:   Object literal may only specify known properties, and 'name' does not exist in type 'Action'.
     ]
@@ -46,11 +46,11 @@ tests/cases/compiler/arrayLiteralTypeInference.ts(32,18): error TS2322: Type '{
     var z1: { id: number }[] =
         [
             { id: 2, trueness: false },
-                     ~~~~~~~~~~~~~~~
+                     ~~~~~~~~
 !!! error TS2322: Type '{ id: number; trueness: false; }' is not assignable to type '{ id: number; }'.
 !!! error TS2322:   Object literal may only specify known properties, and 'trueness' does not exist in type '{ id: number; }'.
             { id: 3, name: "three" }
-                     ~~~~~~~~~~~~~
+                     ~~~~
 !!! error TS2322: Type '{ id: number; name: string; }' is not assignable to type '{ id: number; }'.
 !!! error TS2322:   Object literal may only specify known properties, and 'name' does not exist in type '{ id: number; }'.
         ]

tests/baselines/reference/arrayLiterals.errors.txt

@@ -29,11 +29,11 @@ tests/cases/conformance/expressions/arrayLiterals/arrayLiterals.ts(24,101): erro
 
     // Contextual type C with numeric index signature makes array literal of EveryType E of type BCT(E,C)[]
     var context1: { [n: number]: { a: string; b: number; }; } = [{ a: '', b: 0, c: '' }, { a: "", b: 3, c: 0 }];
-                                                                                ~~~~~
+                                                                                ~
 !!! error TS2322: Type '{ a: string; b: number; c: string; }' is not assignable to type '{ a: string; b: number; }'.
 !!! error TS2322:   Object literal may only specify known properties, and 'c' does not exist in type '{ a: string; b: number; }'.
 !!! related TS6501 tests/cases/conformance/expressions/arrayLiterals/arrayLiterals.ts:24:17: The expected type comes from this index signature.
-                                                                                                        ~~~~
+                                                                                                        ~
 !!! error TS2322: Type '{ a: string; b: number; c: number; }' is not assignable to type '{ a: string; b: number; }'.
 !!! error TS2322:   Object literal may only specify known properties, and 'c' does not exist in type '{ a: string; b: number; }'.
 !!! related TS6501 tests/cases/conformance/expressions/arrayLiterals/arrayLiterals.ts:24:17: The expected type comes from this index signature.

tests/baselines/reference/assignmentCompatBug2.errors.txt

@@ -11,17 +11,17 @@ tests/cases/compiler/assignmentCompatBug2.ts(33,1): error TS2741: Property 'm' i
 
 ==== tests/cases/compiler/assignmentCompatBug2.ts (6 errors) ====
     var b2: { b: number;} = { a: 0 }; // error
-                              ~~~~
+                              ~
 !!! error TS2322: Type '{ a: number; }' is not assignable to type '{ b: number; }'.
 !!! error TS2322:   Object literal may only specify known properties, and 'a' does not exist in type '{ b: number; }'.
 
     b2 = { a: 0 }; // error
-           ~~~~
+           ~
 !!! error TS2322: Type '{ a: number; }' is not assignable to type '{ b: number; }'.
 !!! error TS2322:   Object literal may only specify known properties, and 'a' does not exist in type '{ b: number; }'.
 
     b2 = {b: 0, a: 0 };
-                ~~~~
+                ~
 !!! error TS2322: Type '{ b: number; a: number; }' is not assignable to type '{ b: number; }'.
 !!! error TS2322:   Object literal may only specify known properties, and 'a' does not exist in type '{ b: number; }'.
 

tests/baselines/reference/assignmentCompatBug5.errors.txt

@@ -12,7 +12,7 @@ tests/cases/compiler/assignmentCompatBug5.ts(9,6): error TS2345: Argument of typ
 ==== tests/cases/compiler/assignmentCompatBug5.ts (5 errors) ====
     function foo1(x: { a: number; }) { }
     foo1({ b: 5 });
-           ~~~~
+           ~
 !!! error TS2345: Argument of type '{ b: number; }' is not assignable to parameter of type '{ a: number; }'.
 !!! error TS2345:   Object literal may only specify known properties, and 'b' does not exist in type '{ a: number; }'.
 

tests/baselines/reference/checkJsdocSatisfiesTag1.errors.txt

@@ -28,7 +28,7 @@
 
     const t1 = /** @satisfies {T1} */ ({ a: 1 });
     const t2 = /** @satisfies {T1} */ ({ a: 1, b: 1 });
-                                               ~~~~
+                                               ~
 !!! error TS1360: Type '{ a: number; b: number; }' does not satisfy the expected type 'T1'.
 !!! error TS1360:   Object literal may only specify known properties, and 'b' does not exist in type 'T1'.
     const t3 = /** @satisfies {T1} */ ({});
@@ -45,7 +45,7 @@
     const t6 = /** @satisfies {[number, number]} */ ([1, 2]);
     const t7 = /** @satisfies {T4} */ ({ a: 'test' });
     const t8 = /** @satisfies {T4} */ ({ a: 'test', b: 'test' });
-                                                    ~~~~~~~~~
+                                                    ~
 !!! error TS1360: Type '{ a: string; b: string; }' does not satisfy the expected type 'T4'.
 !!! error TS1360:   Object literal may only specify known properties, and 'b' does not exist in type 'T4'.
 

tests/baselines/reference/checkJsdocSatisfiesTag10.errors.txt

@@ -10,7 +10,7 @@
         a: 0,
         b: "hello",
         x: 8 // Should error, 'x' isn't in 'Keys'
-        ~~~~
+        ~
 !!! error TS1360: Type '{ a: number; b: string; x: number; }' does not satisfy the expected type 'Partial<Record<Keys, unknown>>'.
 !!! error TS1360:   Object literal may only specify known properties, and 'x' does not exist in type 'Partial<Record<Keys, unknown>>'.
     });

tests/baselines/reference/checkJsdocSatisfiesTag12.errors.txt

@@ -30,7 +30,7 @@
      * @satisfies {T1}
      */
     const t2 = { a: 1, b: 1 };
-                       ~~~~
+                       ~
 !!! error TS1360: Type '{ a: number; b: number; }' does not satisfy the expected type 'T1'.
 !!! error TS1360:   Object literal may only specify known properties, and 'b' does not exist in type 'T1'.
 
@@ -53,7 +53,7 @@
      * @satisfies {T2}
      */
     const t6 = { a: 'test', b: 'test' };
-                            ~~~~~~~~~
+                            ~
 !!! error TS1360: Type '{ a: string; b: string; }' does not satisfy the expected type 'T2'.
 !!! error TS1360:   Object literal may only specify known properties, and 'b' does not exist in type 'T2'.
 

tests/baselines/reference/checkJsdocSatisfiesTag13.errors.txt

@@ -8,7 +8,7 @@
 
     /** @satisfies {{ f: (x: string) => string }} */
     const t2 = { g: "oops" }; // should error
-                 ~~~~~~~~~
+                 ~
 !!! error TS1360: Type '{ g: string; }' does not satisfy the expected type '{ f: (x: string) => string; }'.
 !!! error TS1360:   Object literal may only specify known properties, and 'g' does not exist in type '{ f: (x: string) => string; }'.