Make unused variable rule a warning, error on warnings for CI (#58059)

jakebailey · web-flow · commit 438650128599 · 2024-04-03T10:29:27.000-07:00
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -110,7 +110,7 @@
             }
         ],
         "@typescript-eslint/no-unused-vars": [
-            "error",
+            "warn",
             {
                 // Ignore: (solely underscores | starting with exactly one underscore)
                 "argsIgnorePattern": "^(_+$|_[^_])",
diff --git a/Herebyfile.mjs b/Herebyfile.mjs
@@ -538,6 +538,8 @@ export const lint = task({
             "--format",
             formatter,
             "--report-unused-disable-directives",
+            "--max-warnings",
+            "0",
         ];
 
         if (cmdLineOptions.fix) {

Original file line number	Diff line number	Diff line change
`@@ -110,7 +110,7 @@`
`110`	`110`	`}`
`111`	`111`	`],`
`112`	`112`	`"@typescript-eslint/no-unused-vars": [`
`113`		`- "error",`
	`113`	`+ "warn",`
`114`	`114`	`{`
`115`	`115`	`// Ignore: (solely underscores \| starting with exactly one underscore)`
`116`	`116`	`"argsIgnorePattern": "^(_+$\|_[^_])",`