Skip to content

Commit 2217319

Browse files
committed
fix existing tests
1 parent 093326d commit 2217319

File tree

2 files changed

+22
-14
lines changed

2 files changed

+22
-14
lines changed

tests/baselines/reference/inlineJsxFactoryDeclarationsLocalTypes.errors.txt

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,11 @@
11
tests/cases/conformance/jsx/inline/index.tsx(5,1): error TS2741: Property '__predomBrand' is missing in type 'import("tests/cases/conformance/jsx/inline/renderer").dom.JSX.Element' but required in type 'import("tests/cases/conformance/jsx/inline/renderer2").predom.JSX.Element'.
22
tests/cases/conformance/jsx/inline/index.tsx(21,40): error TS2322: Type 'import("tests/cases/conformance/jsx/inline/renderer").dom.JSX.Element' is not assignable to type 'import("tests/cases/conformance/jsx/inline/renderer2").predom.JSX.Element'.
3-
tests/cases/conformance/jsx/inline/index.tsx(21,40): error TS2605: JSX element type 'MyClass' is not a constructor function for JSX elements.
4-
Property '__domBrand' is missing in type 'MyClass' but required in type 'ElementClass'.
3+
tests/cases/conformance/jsx/inline/index.tsx(21,41): error TS2774: This expression cannot be used as a JSX component.
4+
Its instance type 'MyClass' is not a valid JSX element.
5+
Property '__domBrand' is missing in type 'MyClass' but required in type 'ElementClass'.
56
tests/cases/conformance/jsx/inline/index.tsx(21,63): error TS2322: Type 'import("tests/cases/conformance/jsx/inline/renderer").dom.JSX.Element' is not assignable to type 'import("tests/cases/conformance/jsx/inline/renderer2").predom.JSX.Element'.
6-
tests/cases/conformance/jsx/inline/index.tsx(21,63): error TS2605: JSX element type 'MyClass' is not a constructor function for JSX elements.
7+
tests/cases/conformance/jsx/inline/index.tsx(21,64): error TS2774: This expression cannot be used as a JSX component.
8+
Its instance type 'MyClass' is not a valid JSX element.
79
tests/cases/conformance/jsx/inline/index.tsx(24,42): error TS2741: Property '__domBrand' is missing in type 'import("tests/cases/conformance/jsx/inline/renderer2").predom.JSX.Element' but required in type 'import("tests/cases/conformance/jsx/inline/renderer").dom.JSX.Element'.
810
tests/cases/conformance/jsx/inline/index.tsx(24,48): error TS2322: Type 'import("tests/cases/conformance/jsx/inline/renderer2").predom.JSX.Element' is not assignable to type 'import("tests/cases/conformance/jsx/inline/renderer").dom.JSX.Element'.
911

@@ -95,14 +97,16 @@ tests/cases/conformance/jsx/inline/index.tsx(24,48): error TS2322: Type 'import(
9597
const _brokenTree = <MySFC x={1} y={2}><MyClass x={3} y={4} /><MyClass x={5} y={6} /></MySFC>
9698
~~~~~~~~~~~~~~~~~~~~~~~
9799
!!! error TS2322: Type 'import("tests/cases/conformance/jsx/inline/renderer").dom.JSX.Element' is not assignable to type 'import("tests/cases/conformance/jsx/inline/renderer2").predom.JSX.Element'.
98-
~~~~~~~~~~~~~~~~~~~~~~~
99-
!!! error TS2605: JSX element type 'MyClass' is not a constructor function for JSX elements.
100-
!!! error TS2605: Property '__domBrand' is missing in type 'MyClass' but required in type 'ElementClass'.
100+
~~~~~~~
101+
!!! error TS2774: This expression cannot be used as a JSX component.
102+
!!! error TS2774: Its instance type 'MyClass' is not a valid JSX element.
103+
!!! error TS2774: Property '__domBrand' is missing in type 'MyClass' but required in type 'ElementClass'.
101104
!!! related TS2728 tests/cases/conformance/jsx/inline/renderer.d.ts:7:13: '__domBrand' is declared here.
102105
~~~~~~~~~~~~~~~~~~~~~~~
103106
!!! error TS2322: Type 'import("tests/cases/conformance/jsx/inline/renderer").dom.JSX.Element' is not assignable to type 'import("tests/cases/conformance/jsx/inline/renderer2").predom.JSX.Element'.
104-
~~~~~~~~~~~~~~~~~~~~~~~
105-
!!! error TS2605: JSX element type 'MyClass' is not a constructor function for JSX elements.
107+
~~~~~~~
108+
!!! error TS2774: This expression cannot be used as a JSX component.
109+
!!! error TS2774: Its instance type 'MyClass' is not a valid JSX element.
106110

107111
// Should fail, nondom isn't allowed as children of dom
108112
const _brokenTree2 = <DOMSFC x={1} y={2}>{tree}{tree}</DOMSFC>
Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
1-
tests/cases/conformance/jsx/file.tsx(9,13): error TS2605: JSX element type 'undefined' is not a constructor function for JSX elements.
2-
tests/cases/conformance/jsx/file.tsx(10,11): error TS2605: JSX element type 'undefined' is not a constructor function for JSX elements.
1+
tests/cases/conformance/jsx/file.tsx(9,14): error TS2774: This expression cannot be used as a JSX component.
2+
Its return type 'undefined' is not a valid JSX element.
3+
tests/cases/conformance/jsx/file.tsx(10,12): error TS2774: This expression cannot be used as a JSX component.
4+
Its return type 'undefined' is not a valid JSX element.
35

46

57
==== tests/cases/conformance/jsx/file.tsx (2 errors) ====
@@ -12,8 +14,10 @@ tests/cases/conformance/jsx/file.tsx(10,11): error TS2605: JSX element type 'und
1214

1315
// Error
1416
const foo = <Foo />;
15-
~~~~~~~
16-
!!! error TS2605: JSX element type 'undefined' is not a constructor function for JSX elements.
17+
~~~
18+
!!! error TS2774: This expression cannot be used as a JSX component.
19+
!!! error TS2774: Its return type 'undefined' is not a valid JSX element.
1720
const G = <Greet />;
18-
~~~~~~~~~
19-
!!! error TS2605: JSX element type 'undefined' is not a constructor function for JSX elements.
21+
~~~~~
22+
!!! error TS2774: This expression cannot be used as a JSX component.
23+
!!! error TS2774: Its return type 'undefined' is not a valid JSX element.

0 commit comments

Comments
 (0)