Test for isNewIdentifierLocation, and make true for type with index signature (#22910)

Author: Andy

src/harness/fourslash.ts

@@ -840,8 +840,8 @@ namespace FourSlash {
                 this.raiseError(`No completions at position '${this.currentCaretPosition}'.`);
             }
 
-            if (options && options.isNewIdentifierLocation !== undefined && actualCompletions.isNewIdentifierLocation !== options.isNewIdentifierLocation) {
-                this.raiseError(`Expected 'isNewIdentifierLocation' to be ${options.isNewIdentifierLocation}, got ${actualCompletions.isNewIdentifierLocation}`);
+            if (actualCompletions.isNewIdentifierLocation !== (options && options.isNewIdentifierLocation || false)) {
+                this.raiseError(`Expected 'isNewIdentifierLocation' to be ${options && options.isNewIdentifierLocation}, got ${actualCompletions.isNewIdentifierLocation}`);
             }
 
             const actual = actualCompletions.entries;

src/services/completions.ts

@@ -1031,6 +1031,8 @@ namespace ts.Completions {
         }
 
         function addTypeProperties(type: Type): void {
+            isNewIdentifierLocation = !!type.getStringIndexType() || !!type.getNumberIndexType();
+
             if (isSourceFileJavaScript(sourceFile)) {
                 // In javascript files, for union types, we don't just get the members that
                 // the individual types have in common, we also include all the members that

tests/cases/fourslash/completionForStringLiteral7.ts

@@ -5,6 +5,8 @@
 ////function f(x: T, ...args: U[]) { };
 ////f("/*1*/", "/*2*/", "/*3*/");
 
-verify.completionsAt("1", ["foo", "bar"]);
-verify.completionsAt("2", ["oof", "rab"]);
-verify.completionsAt("3", ["oof", "rab"]);
+// TODO: GH#22907
+const options = { isNewIdentifierLocation: true };
+verify.completionsAt("1", ["foo", "bar"], options);
+verify.completionsAt("2", ["oof", "rab"], options);
+verify.completionsAt("3", ["oof", "rab"], options);

tests/cases/fourslash/completionListInClosedObjectTypeLiteralInSignature04.ts

@@ -7,10 +7,4 @@
 ////
 ////declare function foo<TString, TNumber>(obj: I<TString, TNumber>): { /*1*/ }
 
-goTo.marker("1");
-
-verify.not.completionListContains("I");
-verify.not.completionListContains("TString");
-verify.not.completionListContains("TNumber");
-verify.not.completionListContains("foo");
-verify.not.completionListContains("obj");
+verify.completionsAt("1", ["readonly"], { isNewIdentifierLocation: true });

tests/cases/fourslash/completionListInImportClause05.ts

@@ -17,4 +17,4 @@ verify.completionsAt("1", [
     { name: "@a/b", replacementSpan },
     { name: "@c/d", replacementSpan },
     { name: "@e/f", replacementSpan },
-]);
+], { isNewIdentifierLocation: true });

tests/cases/fourslash/completionListInImportClause06.ts

@@ -14,4 +14,4 @@
 // Confirm that entries are de-dup'd.
 verify.completionsAt("1", [
     { name: "@a/b", replacementSpan: test.ranges()[0] },
-]);
+], { isNewIdentifierLocation: true });

tests/cases/fourslash/completionListInUnclosedObjectTypeLiteralInSignature04.ts

@@ -7,4 +7,4 @@
 ////
 ////declare function foo<TString, TNumber>(obj: I<TString, TNumber>): { /*1*/
 
-verify.completionsAt("1", ["readonly"]);
+verify.completionsAt("1", ["readonly"], { isNewIdentifierLocation: true });

tests/cases/fourslash/completionListInvalidMemberNames.ts

@@ -14,7 +14,8 @@
 ////x[|./*a*/|];
 ////x["/*b*/"];
 
-verify.completionsAt("b", ["foo ", "bar", "break", "any", "#", "$", "b", "1b"]);
+// TODO: GH#22907
+verify.completionsAt("b", ["foo ", "bar", "break", "any", "#", "$", "b", "1b"], { isNewIdentifierLocation: true });
 
 const replacementSpan = test.ranges()[0];
 verify.completionsAt("a", [

tests/cases/fourslash/completionListWithModulesInsideModuleScope.ts

@@ -311,7 +311,7 @@ goToMarkAndGeneralVerify('class', { isClassScope: true });
 //verify.not.completionListContains('ceVar');
 
 // from interface in mod1
-verify.completionsAt("interface", ["readonly"]);
+verify.completionsAt("interface", ["readonly"], { isNewIdentifierLocation: true });
 
 // from namespace in mod1
 verifyNamespaceInMod1('namespace');
@@ -348,7 +348,7 @@ verify.not.completionListContains('ceFunc');
 verify.not.completionListContains('ceVar');
 
 // from exported interface in mod1
-verify.completionsAt("exportedInterface", ["readonly"]);
+verify.completionsAt("exportedInterface", ["readonly"], { isNewIdentifierLocation: true });
 
 // from exported namespace in mod1
 verifyExportedNamespace('exportedNamespace');

tests/cases/fourslash/completionsInterfaceElement.ts

@@ -14,5 +14,5 @@
 ////interface EndOfFile { f; /*e*/
 
 for (const marker of test.markerNames()) {
-    verify.completionsAt(marker, ["readonly"]);
+    verify.completionsAt(marker, ["readonly"], { isNewIdentifierLocation: true });
 }