Add JSDocOverloadTag to ForEachChildTable (#51907)

* add JSDocOverloadTag to ForEachChildTable

* fix tests

* change imports order

Author: a-tarasyuk

src/compiler/parser.ts

@@ -1105,6 +1105,7 @@ const forEachChildTable: ForEachChildTable = {
     [SyntaxKind.JSDocThisTag]: forEachChildInJSDocTypeLikeTag,
     [SyntaxKind.JSDocEnumTag]: forEachChildInJSDocTypeLikeTag,
     [SyntaxKind.JSDocThrowsTag]: forEachChildInJSDocTypeLikeTag,
+    [SyntaxKind.JSDocOverloadTag]: forEachChildInJSDocTypeLikeTag,
     [SyntaxKind.JSDocSignature]: function forEachChildInJSDocSignature<T>(node: JSDocSignature, cbNode: (node: Node) => T | undefined, _cbNodes?: (nodes: NodeArray<Node>) => T | undefined): T | undefined {
         return forEach(node.typeParameters, cbNode) ||
             forEach(node.parameters, cbNode) ||
@@ -1198,7 +1199,7 @@ function forEachChildInJSDocParameterOrPropertyTag<T>(node: JSDocParameterTag |
         (typeof node.comment === "string" ? undefined : visitNodes(cbNode, cbNodes, node.comment));
 }
 
-function forEachChildInJSDocTypeLikeTag<T>(node: JSDocReturnTag | JSDocTypeTag | JSDocThisTag | JSDocEnumTag | JSDocThrowsTag, cbNode: (node: Node) => T | undefined, cbNodes?: (nodes: NodeArray<Node>) => T | undefined): T | undefined {
+function forEachChildInJSDocTypeLikeTag<T>(node: JSDocReturnTag | JSDocTypeTag | JSDocThisTag | JSDocEnumTag | JSDocThrowsTag | JSDocOverloadTag, cbNode: (node: Node) => T | undefined, cbNodes?: (nodes: NodeArray<Node>) => T | undefined): T | undefined {
     return visitNode(cbNode, node.tagName) ||
         visitNode(cbNode, node.typeExpression) ||
         (typeof node.comment === "string" ? undefined : visitNodes(cbNode, cbNodes, node.comment));

src/compiler/types.ts

@@ -1002,6 +1002,7 @@ export type ForEachChildNodes =
     | JSDocDeprecatedTag
     | JSDocThrowsTag
     | JSDocOverrideTag
+    | JSDocOverloadTag
     ;
 
 /** @internal */

src/compiler/utilitiesPublic.ts

@@ -75,6 +75,7 @@ import {
     getElementOrPropertyAccessArgumentExpressionOrName,
     getEmitScriptTarget,
     getJSDocCommentsAndTags,
+    getJSDocRoot,
     getJSDocTypeParameterDeclarations,
     hasAccessorModifier,
     hasDecorators,
@@ -191,6 +192,7 @@ import {
     LabeledStatement,
     lastOrUndefined,
     LeftHandSideExpression,
+    length,
     LiteralExpression,
     LiteralToken,
     MemberName,
@@ -1210,12 +1212,10 @@ function formatJSDocLink(link: JSDocLink | JSDocLinkCode | JSDocLinkPlain) {
  */
 export function getEffectiveTypeParameterDeclarations(node: DeclarationWithTypeParameters): readonly TypeParameterDeclaration[] {
     if (isJSDocSignature(node)) {
-        if (isJSDoc(node.parent)) {
-            const overloadTag = find(node.parent.tags, (tag) => {
-                return isJSDocOverloadTag(tag) && tag.typeExpression === node;
-            });
-            if (overloadTag) {
-                return flatMap(node.parent.tags, tag => isJSDocTemplateTag(tag) ? tag.typeParameters : undefined);
+        if (isJSDocOverloadTag(node.parent)) {
+            const jsDoc = getJSDocRoot(node.parent);
+            if (jsDoc && length(jsDoc.tags)) {
+                return flatMap(jsDoc.tags, tag => isJSDocTemplateTag(tag) ? tag.typeParameters : undefined);
             }
         }
         return emptyArray;