Skip to content

Commit 20550fd

Browse files
committed
Don't npm install the parent project with no args
1 parent 3b919e2 commit 20550fd

File tree

4 files changed

+11
-23
lines changed

4 files changed

+11
-23
lines changed

src/testRunner/externalCompileRunner.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ namespace Harness {
7676
exec("npm", ["i", "--ignore-scripts"], { cwd, timeout: timeout / 2 }); // NPM shouldn't take the entire timeout - if it takes a long time, it should be terminated and we should log the failure
7777
}
7878
const args = [path.join(IO.getWorkspaceRoot(), "built/local/tsc.js")];
79-
if (types) {
79+
if (types?.length) {
8080
args.push("--types", types.join(","));
8181
// Also actually install those types (for, eg, the js projects which need node)
8282
exec("npm", ["i", ...types.map(t => `@types/${t}`), "--no-save", "--ignore-scripts"], { cwd: originalCwd, timeout: timeout / 2 }); // NPM shouldn't take the entire timeout - if it takes a long time, it should be terminated and we should log the failure
@@ -337,4 +337,4 @@ ${stderr.replace(/\r\n/g, "\n")}`;
337337
}
338338
return result;
339339
}
340-
}
340+
}

tests/baselines/reference/user/TypeScript-Vue-Starter.log

-9
This file was deleted.

tests/baselines/reference/user/TypeScript-WeChat-Starter.log

+7-11
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,12 @@
11
Exit Code: 1
22
Standard output:
3-
src/App.test.tsx(5,1): error TS2593: Cannot find name 'it'. Do you need to install type definitions for a test runner? Try `npm i @types/jest` or `npm i @types/mocha` and then add `jest` or `mocha` to the types field in your tsconfig.
4-
src/components/Hello.test.tsx(5,1): error TS2593: Cannot find name 'it'. Do you need to install type definitions for a test runner? Try `npm i @types/jest` or `npm i @types/mocha` and then add `jest` or `mocha` to the types field in your tsconfig.
5-
src/components/Hello.test.tsx(7,3): error TS2304: Cannot find name 'expect'.
6-
src/components/Hello.test.tsx(10,1): error TS2593: Cannot find name 'it'. Do you need to install type definitions for a test runner? Try `npm i @types/jest` or `npm i @types/mocha` and then add `jest` or `mocha` to the types field in your tsconfig.
7-
src/components/Hello.test.tsx(12,3): error TS2304: Cannot find name 'expect'.
8-
src/components/Hello.test.tsx(15,1): error TS2593: Cannot find name 'it'. Do you need to install type definitions for a test runner? Try `npm i @types/jest` or `npm i @types/mocha` and then add `jest` or `mocha` to the types field in your tsconfig.
9-
src/components/Hello.test.tsx(17,3): error TS2304: Cannot find name 'expect'.
10-
src/components/Hello.test.tsx(20,1): error TS2593: Cannot find name 'it'. Do you need to install type definitions for a test runner? Try `npm i @types/jest` or `npm i @types/mocha` and then add `jest` or `mocha` to the types field in your tsconfig.
11-
src/components/Hello.test.tsx(21,3): error TS2304: Cannot find name 'expect'.
12-
src/components/Hello.test.tsx(26,1): error TS2593: Cannot find name 'it'. Do you need to install type definitions for a test runner? Try `npm i @types/jest` or `npm i @types/mocha` and then add `jest` or `mocha` to the types field in your tsconfig.
13-
src/components/Hello.test.tsx(27,3): error TS2304: Cannot find name 'expect'.
3+
../../../../../node_modules/@types/mocha/index.d.ts(2680,13): error TS2403: Subsequent variable declarations must have the same type. Variable 'beforeEach' must be of type 'Lifecycle', but here has type 'HookFunction'.
4+
../../../../../node_modules/@types/mocha/index.d.ts(2698,13): error TS2403: Subsequent variable declarations must have the same type. Variable 'afterEach' must be of type 'Lifecycle', but here has type 'HookFunction'.
5+
../../../../../node_modules/@types/mocha/index.d.ts(2714,13): error TS2403: Subsequent variable declarations must have the same type. Variable 'describe' must be of type 'Describe', but here has type 'SuiteFunction'.
6+
../../../../../node_modules/@types/mocha/index.d.ts(2735,13): error TS2403: Subsequent variable declarations must have the same type. Variable 'xdescribe' must be of type 'Describe', but here has type 'PendingSuiteFunction'.
7+
../../../../../node_modules/@types/mocha/index.d.ts(2749,13): error TS2403: Subsequent variable declarations must have the same type. Variable 'it' must be of type 'It', but here has type 'TestFunction'.
8+
../../../../../node_modules/@types/mocha/index.d.ts(2763,13): error TS2403: Subsequent variable declarations must have the same type. Variable 'test' must be of type 'It', but here has type 'TestFunction'.
9+
../../../../../node_modules/@types/mocha/index.d.ts(2770,13): error TS2403: Subsequent variable declarations must have the same type. Variable 'xit' must be of type 'It', but here has type 'PendingTestFunction'.
1410

1511

1612

tests/baselines/reference/user/puppeteer.log

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
Exit Code: 1
22
Standard output:
3+
../../../../../node_modules/@types/gulp/index.d.ts(9,27): error TS2307: Cannot find module 'chokidar'.
34
lib/Accessibility.js(134,15): error TS2503: Cannot find namespace 'Protocol'.
45
lib/Accessibility.js(344,7): error TS2322: Type 'string | number | boolean' is not assignable to type 'never'.
56
Type 'string' is not assignable to type 'never'.
@@ -55,7 +56,7 @@ lib/Page.js(94,33): error TS2345: Argument of type 'CDPSession' is not assignabl
5556
lib/Page.js(147,15): error TS2503: Cannot find namespace 'Protocol'.
5657
lib/Page.js(220,15): error TS2503: Cannot find namespace 'Protocol'.
5758
lib/Page.js(388,20): error TS2503: Cannot find namespace 'Protocol'.
58-
lib/Page.js(451,7): error TS2740: Type '(...args: any[]) => Promise<any>' is missing the following properties from type 'Window': applicationCache, clientInformation, closed, customElements, and 222 more.
59+
lib/Page.js(451,7): error TS2740: Type '(...args: any[]) => Promise<any>' is missing the following properties from type 'Window': applicationCache, clientInformation, closed, customElements, and 241 more.
5960
lib/Page.js(461,9): error TS2349: This expression is not callable.
6061
Type 'Window' has no call signatures.
6162
lib/Page.js(497,15): error TS2503: Cannot find namespace 'Protocol'.

0 commit comments

Comments
 (0)