Fix error on qualified names in type queries

Author: andrewbranch

src/compiler/checker.ts

@@ -1865,7 +1865,7 @@ namespace ts {
         }
 
         function checkSymbolUsageInExpressionContext(symbol: Symbol, name: __String, useSite: Node) {
-            if (!(useSite.flags & NodeFlags.Ambient) && isInExpressionContext(useSite)) {
+            if (!(useSite.flags & NodeFlags.Ambient) && !isPartOfTypeQuery(useSite) && isExpressionNode(useSite)) {
                 const typeOnlyDeclaration = getTypeOnlyAliasDeclaration(symbol);
                 if (typeOnlyDeclaration) {
                     const message = typeOnlyDeclaration.kind === SyntaxKind.ExportSpecifier

src/compiler/utilities.ts

@@ -1771,6 +1771,13 @@ namespace ts {
         }
     }
 
+    export function isPartOfTypeQuery(node: Node) {
+        while (node.kind === SyntaxKind.QualifiedName || node.kind === SyntaxKind.Identifier) {
+            node = node.parent;
+        }
+        return node.kind === SyntaxKind.TypeQuery;
+    }
+
     export function isExternalModuleImportEqualsDeclaration(node: Node): node is ImportEqualsDeclaration & { moduleReference: ExternalModuleReference } {
         return node.kind === SyntaxKind.ImportEqualsDeclaration && (<ImportEqualsDeclaration>node).moduleReference.kind === SyntaxKind.ExternalModuleReference;
     }

tests/baselines/reference/namespaceImportTypeQuery.errors.txt

@@ -0,0 +1,15 @@
+/b.ts(2,21): error TS2339: Property 'A' does not exist on type 'typeof import("/a")'.
+
+
+==== /a.ts (0 errors) ====
+    class A {}
+    export type { A };
+    export class B {};
+    
+==== /b.ts (1 errors) ====
+    import * as types from './a';
+    let A: typeof types.A;
+                        ~
+!!! error TS2339: Property 'A' does not exist on type 'typeof import("/a")'.
+    let B: typeof types.B;
+    

tests/baselines/reference/namespaceImportTypeQuery.js

@@ -0,0 +1,33 @@
+//// [tests/cases/conformance/externalModules/typeOnly/namespaceImportTypeQuery.ts] ////
+
+//// [a.ts]
+class A {}
+export type { A };
+export class B {};
+
+//// [b.ts]
+import * as types from './a';
+let A: typeof types.A;
+let B: typeof types.B;
+
+
+//// [a.js]
+"use strict";
+exports.__esModule = true;
+var A = /** @class */ (function () {
+    function A() {
+    }
+    return A;
+}());
+var B = /** @class */ (function () {
+    function B() {
+    }
+    return B;
+}());
+exports.B = B;
+;
+//// [b.js]
+"use strict";
+exports.__esModule = true;
+var A;
+var B;

tests/baselines/reference/namespaceImportTypeQuery.symbols

@@ -0,0 +1,24 @@
+=== /a.ts ===
+class A {}
+>A : Symbol(A, Decl(a.ts, 0, 0))
+
+export type { A };
+>A : Symbol(A, Decl(a.ts, 1, 13))
+
+export class B {};
+>B : Symbol(B, Decl(a.ts, 1, 18))
+
+=== /b.ts ===
+import * as types from './a';
+>types : Symbol(types, Decl(b.ts, 0, 6))
+
+let A: typeof types.A;
+>A : Symbol(A, Decl(b.ts, 1, 3))
+>types : Symbol(types, Decl(b.ts, 0, 6))
+
+let B: typeof types.B;
+>B : Symbol(B, Decl(b.ts, 2, 3))
+>types.B : Symbol(types.B, Decl(a.ts, 1, 18))
+>types : Symbol(types, Decl(b.ts, 0, 6))
+>B : Symbol(types.B, Decl(a.ts, 1, 18))
+

tests/baselines/reference/namespaceImportTypeQuery.types

@@ -0,0 +1,26 @@
+=== /a.ts ===
+class A {}
+>A : A
+
+export type { A };
+>A : A
+
+export class B {};
+>B : B
+
+=== /b.ts ===
+import * as types from './a';
+>types : typeof types
+
+let A: typeof types.A;
+>A : any
+>types.A : any
+>types : typeof types
+>A : any
+
+let B: typeof types.B;
+>B : typeof types.B
+>types.B : typeof types.B
+>types : typeof types
+>B : typeof types.B
+

tests/cases/conformance/externalModules/typeOnly/namespaceImportTypeQuery.ts

@@ -0,0 +1,9 @@
+// @Filename: /a.ts
+class A {}
+export type { A };
+export class B {};
+
+// @Filename: /b.ts
+import * as types from './a';
+let A: typeof types.A;
+let B: typeof types.B;