Hide "Was this page helpful?" popup from focus when not visible #2271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jakebailey
approved these changes
May 18, 2023
|
Hm, #2338 was accepted first. Probably this could replace it if it still works? |
|
Going to just close this; the other fix came from the accessibility team so I think the current state is "good enough". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Elements that get hidden with
opacity: 0still get exposed to keyboard users and are potentially focusable, even while they are invisible and are ignored by some (not all) screen readers. Whiledisplay: noneon the elements would remove the transitions,visibility: hiddenshould not have this effect in modern browsers and should correctly remove its children from focus order. The transitions should still be tested by someone else for good measure.Other components on the website probably require similar changes to be made accessible.