Adding capability for ternary expression as a separate scope #129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -26,11 +26,18 @@ repository: | |||
| '1': { name: variable.ts } | |||
| end: (?=$|[;,]) | |||
| patterns: | |||
| - include: '#ternary-operator' | |||
There was a problem hiding this comment.
Why isn't ternary-operator just part of expression?
There was a problem hiding this comment.
If what you mean is why we need a 'ternary-operator' as a new addition, there are 2 reasons I can think of:
- To make (? + expression + :) together
- #Type-annotation consumes " : followed by something" before we can get to #expression. Even if we change the order in which they are present. It will include : followed by something as #type-annotation instead of skipping it to look for an expression.
| patterns: | ||
| - include: '#ternary-expression-type' | ||
|
|
||
| ternary-expression-type: |
There was a problem hiding this comment.
Can you document (in comments) exactly what this is supposed to capture? For instance, why do you need types covered here?
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solving Issue #124, #80, #81