Syntax highlighting gets confused if return type ends with a number

[aeschli]

From @kayahr on July 4, 2016 11:9

• VSCode Version: 1.2.1
• OS Version: Debian GNU/Linux 8.5

Steps to Reproduce:

1. Open new TypeScript file.
2. Copy/Paste the following code:

class Vector2 {
    public foobar(): Vector2 {
        return this;
    }
}

class Vector2D {
    public foobar(): Vector2D {
        return this;
    }
}

The method in the class Vector2D is properly colored but in the class Vector2 the syntax highlighting gets confused. Looks like this has something to do with the class name ending with a number.

Here is a screenshot showing a wrong color of the return and thiskeywords:

In larger source code this gets quite confusing because subsequent methods in the same class are also affected.

Copied from original issue: microsoft/vscode#8720

[kayahr]

By the way: The same problem can be reproduced right here on Github when formatting source code with language=typescript:

class Vector2 {
    public foobar(): Vector2 {
        return this;
    }
}

class Vector2D {
    public foobar(): Vector2D {
        return this;
    }
}

And a small workaround for the issue is placing the return type in parantheses:

class Vector2 {
    public foobar(): (Vector2) {
        return this;
    }
}

Or using Allman style instead of 1TBS:

class Vector2
{
    public foobar(): Vector2
    {
        return this;
    }
}

[glen-84]

Duplicate of #188 and #153.

[sheetalkamat]

Fixed by #257