Font size in the tooltip

[ddotlic]

Hi,

just realized that with the latest official released version (0.1.4) the tooltips (which I've had for quite some time because I used the HEAD version of the master from github repo) are finally colorized (this did not work - in the sense that popup was black text on white - before and still doesn't if I just clone the repo, weird).

However, the font size is a bit small, let me try to demonstrate:

Is there a way to configure the font size?

[ddotlic]

LOL, I just looked in the package directory, is it really that simple... the popup is - or rather its template is - popup.html??

If so, I can temporarily patch this myself, but you should probably replace the font size by the one actually used in the editor. If you're already doing this (sorry for being ignorant) by, say, reducing the editor's font a little, then the code is a bit too aggressive.

It might actually be the best to simply let us choose the font size via preferences, then replace in the template html.

[ddotlic]

After some experimentation, changing popup.html does affect the output (I actually had a deadlocked instance of sublime invisible but running all along which made me think that this file isn't used).

Next install of the package will still overwrite any and all customizations so the font size should be IMHO customizable (or not just use the same one from the editor) differently.

Thanks for coloring the tooltip, black text on white while using a dark time really 'hurt' my eyes 😄

[zhengbli]

I too believe that the font size of the tooltip should be customizable. We will add that option soon. Appreciate your experiment with the plugin :)

[ddotlic]

@zhengbli No problem, I didn't really do much except tinker a tiny bit.

I also removed the bold font for the tooltip, maybe a better option would be to let people entirely (to the extent that template can/should be customizable) change the template? Not sure how that would work though because the file itself is kept in the plugin's folder and obviously gets rewritten when next update comes.

Thanks again for this plugin!

[zhengbli]

@ddotlic Sorry I just realized that you said you don't have the tooltip if cloning from the repo directly. That is not expected. Do you see any exceptions in the console?

[ddotlic]

I actually have tooltips if I clone the repo, but it has been black text on white ever since I switched to the source version, including now (just pulled latest on this machine).

Here's how it looks

If I delete the folder and install 0.1.4 through Package Manager I can get color tooltips which respect the theme just fine (which is when I've started playing with popup.html to adjust the font size).

I don't want to push this issue (black on white) because most people will use the Package Manager version anyway.

[ddotlic]

And no, I'm not seeing anything of note in the console.

The last 4 lines were:

Package Control: No updated packages
Packages/TypeScript/popup.html
insert_snippet
insert_snippet

[zhengbli]

Looks like the problem only happens for 64 bit Sublime Text on Windows. Is that what you have?

[zhengbli]

I think the problem is that the win 64 version Sublime cannot handle CR line endings in the tooltip html string. Should be fixed in PR #222