Skip to content
This repository was archived by the owner on Nov 16, 2023. It is now read-only.

Migrate from bcrypt-nodejs to bcrypt #283

Closed
wants to merge 2 commits into from
Closed

Migrate from bcrypt-nodejs to bcrypt #283

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented May 8, 2020

Closes #44

@msftclas
Copy link

msftclas commented May 8, 2020

CLA assistant check
All CLA requirements met.

@ghost
Copy link
Author

ghost commented May 8, 2020

Added commits in reference to #285.

@peterblazejewicz
Copy link
Collaborator

These are three different topics here:

  1. chai - seems no brainer, it seems to be left-over from previous implementation detail
  2. bcrypt - this was already discussed on project and raised. In all previous occasions PR owners decided to not update the library, as the bcrypt rquires native dependencies that are not always available for specific installation. E.g. see comment:
    Update bcrypt & node-sass #253 (comment)
  3. model definition - that's not brainer either, OK.

If you could split this PR into focused ones, it would be better to grasp the topics. (make three branches, cherry-pick your commits to topic branch, push pr), it would help

@ghost ghost closed this May 10, 2020
@bluepuma77
Copy link

I tested TypeScript-Node-Starter for the first time today and stumbled upon this:

npm WARN deprecated [email protected]: bcrypt-nodejs is no longer actively maintained. Please use bcrypt or bcryptjs. See https://github.com/kelektiv/node.bcrypt.js/wiki/bcrypt-vs-brypt.js to learn more about these two options

For newcomers it might look like your project is not maintained when using deprecated libraries.

This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typescript model export not working
3 participants