Fix duplicates after merge in addedTypes.json #836
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandersn
requested changes
Mar 17, 2020
| @@ -3700,19 +3685,6 @@ | |||
| } | |||
| } | |||
| }, | |||
| "HTMLVideoElement": { | |||
There was a problem hiding this comment.
I don't see an existing entry where this HTMLVideoElement method is added. Was that an incorrect artifact of the merge too?
There was a problem hiding this comment.
I was confused at first, but looks like you've added it by hand after problematic merge.
#811 (comment)
There was a problem hiding this comment.
sandersn
approved these changes
Mar 17, 2020
|
Thanks for the review! I think that at this point all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that there are problems with in
addedTypes.json(thanks VS Code!) which were related to duplicated entries ininterfaces>interface.I've removed blocks with
cloneNodeand re-run patched helper script to bring them back to existing nodes.Updated baselines should now contain proper overrides and elements names that were skipped because of duplicated keys later in JSON.
Related to #811