Skip to content

Use narrower types for setInterval and setTimeout #810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Use narrower types for setInterval and setTimeout #810

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf48c67
Use narrower types for setInterval and setTimeout
Dec 5, 2019
d2508f8
baseline-accept
Dec 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions baselines/dom.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18739,8 +18739,8 @@ interface WindowOrWorkerGlobalScope {
createImageBitmap(image: ImageBitmapSource, sx: number, sy: number, sw: number, sh: number): Promise<ImageBitmap>;
fetch(input: RequestInfo, init?: RequestInit): Promise<Response>;
queueMicrotask(callback: Function): void;
setInterval(handler: TimerHandler, timeout?: number, ...arguments: any[]): number;
setTimeout(handler: TimerHandler, timeout?: number, ...arguments: any[]): number;
setInterval<H extends TimerHandler>(handler: H, timeout?: number, ...arguments: H extends ((...args: infer A) => any) ? A : any[]): number;
setTimeout<H extends TimerHandler>(handler: H, timeout?: number, ...arguments: H extends ((...args: infer A) => any) ? A : any[]): number;
}

interface WindowSessionStorage {
Expand Down Expand Up @@ -19947,8 +19947,8 @@ declare function createImageBitmap(image: ImageBitmapSource): Promise<ImageBitma
declare function createImageBitmap(image: ImageBitmapSource, sx: number, sy: number, sw: number, sh: number): Promise<ImageBitmap>;
declare function fetch(input: RequestInfo, init?: RequestInit): Promise<Response>;
declare function queueMicrotask(callback: Function): void;
declare function setInterval(handler: TimerHandler, timeout?: number, ...arguments: any[]): number;
declare function setTimeout(handler: TimerHandler, timeout?: number, ...arguments: any[]): number;
declare function setInterval<H extends TimerHandler>(handler: H, timeout?: number, ...arguments: H extends ((...args: infer A) => any) ? A : any[]): number;
declare function setTimeout<H extends TimerHandler>(handler: H, timeout?: number, ...arguments: H extends ((...args: infer A) => any) ? A : any[]): number;
declare var sessionStorage: Storage;
declare var localStorage: Storage;
declare var onafterprint: ((this: Window, ev: Event) => any) | null;
Expand Down
8 changes: 4 additions & 4 deletions baselines/webworker.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5337,8 +5337,8 @@ interface WindowOrWorkerGlobalScope {
createImageBitmap(image: ImageBitmapSource, sx: number, sy: number, sw: number, sh: number): Promise<ImageBitmap>;
fetch(input: RequestInfo, init?: RequestInit): Promise<Response>;
queueMicrotask(callback: Function): void;
setInterval(handler: TimerHandler, timeout?: number, ...arguments: any[]): number;
setTimeout(handler: TimerHandler, timeout?: number, ...arguments: any[]): number;
setInterval<H extends TimerHandler>(handler: H, timeout?: number, ...arguments: H extends ((...args: infer A) => any) ? A : any[]): number;
setTimeout<H extends TimerHandler>(handler: H, timeout?: number, ...arguments: H extends ((...args: infer A) => any) ? A : any[]): number;
}

interface WorkerEventMap extends AbstractWorkerEventMap {
Expand Down Expand Up @@ -5796,8 +5796,8 @@ declare function createImageBitmap(image: ImageBitmapSource): Promise<ImageBitma
declare function createImageBitmap(image: ImageBitmapSource, sx: number, sy: number, sw: number, sh: number): Promise<ImageBitmap>;
declare function fetch(input: RequestInfo, init?: RequestInit): Promise<Response>;
declare function queueMicrotask(callback: Function): void;
declare function setInterval(handler: TimerHandler, timeout?: number, ...arguments: any[]): number;
declare function setTimeout(handler: TimerHandler, timeout?: number, ...arguments: any[]): number;
declare function setInterval<H extends TimerHandler>(handler: H, timeout?: number, ...arguments: H extends ((...args: infer A) => any) ? A : any[]): number;
declare function setTimeout<H extends TimerHandler>(handler: H, timeout?: number, ...arguments: H extends ((...args: infer A) => any) ? A : any[]): number;
declare function cancelAnimationFrame(handle: number): void;
declare function requestAnimationFrame(callback: FrameRequestCallback): number;
declare function addEventListener<K extends keyof DedicatedWorkerGlobalScopeEventMap>(type: K, listener: (this: DedicatedWorkerGlobalScope, ev: DedicatedWorkerGlobalScopeEventMap[K]) => any, options?: boolean | AddEventListenerOptions): void;
Expand Down
19 changes: 19 additions & 0 deletions inputfiles/overridingTypes.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,25 @@
{
"mixins": {
"mixin": {
"WindowOrWorkerGlobalScope": {
"name": "WindowOrWorkerGlobalScope",
"methods": {
"method": {
"setTimeout": {
"name": "setTimeout",
"override-signatures": [
"setTimeout<H extends TimerHandler>(handler: H, timeout?: number, ...arguments: H extends ((...args: infer A) => any) ? A : any[]): number"
]
},
"setInterval": {
"name": "setInterval",
"override-signatures": [
"setInterval<H extends TimerHandler>(handler: H, timeout?: number, ...arguments: H extends ((...args: infer A) => any) ? A : any[]): number"
]
}
}
}
},
"GlobalFetch": {
"name": "GlobalFetch",
"methods": {
Expand Down