Fix incorrect caches.match() type definition #740
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note, some tests are failing, but those tests were failing before I made my changes, and no additional tests were failing after I made my changes. |
saschanaz
approved these changes
Sep 27, 2019
sandersn
approved these changes
Nov 14, 2019
|
webworker baselines weren't updated so I updated them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
CacheStorage.match()method is correctly defined in the IDL doc, but then the overrides file sets the type to the incorrect value.See here that the spec uses
MultiCacheQueryOptionsfor the CacheStorage interface:https://w3c.github.io/ServiceWorker/#cachestorage-interface