Skip to content

Add FullscreenOptions, etc. #593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 24, 2019
Merged

Add FullscreenOptions, etc. #593

merged 3 commits into from
Jan 24, 2019

Conversation

saschanaz
Copy link
Contributor

This adds FullscreenOptions for requestFullscreen() and some comment changes.

@saschanaz
Copy link
Contributor Author

saschanaz commented Nov 1, 2018 •
edited
Loading

It would be great for reviewers if CI can alert when the IDL changes are just hand-written and not from npm run fetch. I have no idea how it could be done.

@HolgerJeromin
Copy link
Contributor

This is a good idea.
But when the upstream source changes the next (unrelated) pr would fail... :-(

@sandersn sandersn merged commit d4492af into microsoft:master Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saschanaz @HolgerJeromin @sandersn