Skip to content

webworker: expose WorkerOptions parameter on constructor #587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 31, 2018
Merged

webworker: expose WorkerOptions parameter on constructor #587

merged 3 commits into from
Oct 31, 2018

Conversation

AviVahl
Copy link
Contributor

@AviVahl AviVahl commented Oct 27, 2018

@msftclas
Copy link

msftclas commented Oct 27, 2018 •
edited
Loading

CLA assistant check
All CLA requirements met.

saschanaz
saschanaz suggested changes Oct 30, 2018
View reviewed changes
saschanaz
saschanaz suggested changes Oct 30, 2018
View reviewed changes
@AviVahl
Copy link
Contributor Author

AviVahl commented Oct 30, 2018

@saschanaz ready for re-review. please let me know if any further changes are needed.

@sandersn
Copy link
Member

@AviVahl can you merge from master before I merge this?

@AviVahl
Copy link
Contributor Author

AviVahl commented Oct 31, 2018

@sandersn rebased to master

@sandersn sandersn merged commit ae27ec9 into microsoft:master Oct 31, 2018
@sandersn
Copy link
Member

Thanks @AviVahl !

@AviVahl AviVahl deleted the support-worker-options branch October 31, 2018 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschanaz saschanaz saschanaz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[lib.webworker.d.ts] Worker constructor type missing optional options
4 participants
@AviVahl @msftclas @sandersn @saschanaz