Detect added json items for static interfaces #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| let getAddedItems kind flavor = | ||
| getItems addedItems kind flavor | ||
| let getRemovedItems kind flavor = | ||
| getItems removedItems kind flavor |
There was a problem hiding this comment.
why not let these be the point-free versions, eg
let getAddedItems = getItems addedItems
|
Besides a minor comment, 👍 |
zhengbli
added a commit
that referenced
this pull request
Jan 25, 2016
Detect added json items for static interfaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue:
For interfaces marked as
staticin the spec, we used to not detect changes made in the external json files.Related to PR #44