Skip to content

Fixed #24084 - Changed HTMLSelectElement Index Signature #510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 26, 2018

Conversation

irrationalRock
Copy link
Contributor

This PR addresses microsoft/TypeScript#24084.

I changed the HTMLSelectElement index to [name: string]: HTMLOptionElement | HTMLOptGroupElement.

Thanks for considering this PR.

@saschanaz
Copy link
Contributor

String indexers generally don't work, unless the target interface has no other members.

@mhegazy
Copy link
Contributor

mhegazy commented Jun 25, 2018

A string indexer type should be of a type that covers every property on the type.

@irrationalRock
Copy link
Contributor Author

Thanks for the comments.

I changed the signature to [name: number]: HTMLOptionElement | HTMLOptGroupElement

@mhegazy mhegazy merged commit ba752e1 into microsoft:master Jun 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants