Skip to content

Proposed fix for issue 501 #502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 13, 2018
Merged

Proposed fix for issue 501 #502

merged 3 commits into from
Jun 13, 2018

Conversation

stevedorries
Copy link
Contributor

Adds proposed function signature overload.

Adds additional overload to document.createElementNS function that accepts an optional ElementCreationOptions argument.
@mhegazy
Copy link
Contributor

mhegazy commented Jun 13, 2018

You need to also include the generated baseline

@msftclas
Copy link

msftclas commented Jun 13, 2018

CLA assistant check
All CLA requirements met.

@stevedorries
Copy link
Contributor Author

Generated baseline is now included.

@mhegazy mhegazy merged commit 8d94cce into microsoft:master Jun 13, 2018
@mhegazy
Copy link
Contributor

mhegazy commented Jun 13, 2018

Sorry i merged that too fast. i think there is one more change needed.. instead of using "additional-signatures" use "override-signatures" to avoid having the extra signature at the bottom.

@HolgerJeromin
Copy link
Contributor

Ref #501

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants