Add HTML text level semantics types #494
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhegazy
reviewed
Jun 11, 2018
| @@ -0,0 +1,13 @@ | |||
| { | |||
| "hyperlink-href": "Returns the hyperlink's URL.\nCan be set, to change the URL.", | |||
There was a problem hiding this comment.
i do not see these comments showing up
There was a problem hiding this comment.
Not sure what should be done there, it seems should be htmlhyperlinkelementutils-href instead of hyperlink-href to add it to the lib file. Should it be manually mapped?
|
Some merge conflicts need attention |
|
looks like my manual merge did not work. |
saschanaz
force-pushed
the
text-semantics
branch
from
0ce9ef7 to
69103b5
Compare
|
Fixed! |
|
thanks! |
|
@saschanaz do you have a list of all the remaining widl files? we should probably have this on an issue to make it easier for others who wanna help to jump in and pick a few. |
|
I don't have one right now, but I hope I can get one after I add full HTML and DOM types. Currently I just try adding those types and getting their dependencies by build errors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes nonstandard properties from HTMLAnchorElement.